Improve block quote formatting#168
Merged
dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom Dec 13, 2019
Merged
Improve block quote formatting#168dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
dscho merged 1 commit intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
Conversation
dscho
previously approved these changes
Dec 13, 2019
f58089f to
9605792
Compare
The fromString function from "html-to-text" does "lazy" quoting with only a leading > for the quote. This makes cover letters that include quoting hard to read. This change adds a blockquote formatter that will put `> ` at the start of each line of the quote. Quoting inside of quotes will only add a `>`. Not perfect but better than relying on mail formatters to handle lazy quoting. Signed-off-by: Chris. Webster <chris@webstech.net>
Contributor
Author
|
This is a fix for issue #161. |
dscho
approved these changes
Dec 13, 2019
Member
|
Very nice, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fromString function from "html-to-text" does "lazy"
quoting with only a leading > for the quote. This makes
cover letters that include quoting hard to read.
This change adds a blockquote formatter that will put
>atthe start of each line of the quote. Quoting inside of quotes
will only add a
>. Not perfect but better than relying onmail formatters to handle lazy quoting.
Signed-off-by: Chris. Webster chris@webstech.net