Switch from public-inbox.org to lore.kernel.org#164
Switch from public-inbox.org to lore.kernel.org#164dscho merged 3 commits intogitgitgadget:mastergitgitgadget/gitgitgadget:masterfrom
Conversation
TSLint pointed out that there were indentation issues and a missing newline at the end of the file Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Searching mail may require searching for public-inbox as well.
Checking config for gitgitgadget.loreGitDir
Changed PUBLIC_INBOX_DIR to LORE_GIT_DIR
Renamed PublicInboxGitHelper -> MailArchiveGitHelper (and file renamed)
Renamed file search-commit-on-public-inbox.sh ->
search-commit-on-mail-archive.sh
Renamed publicInboxGitDir -> mailArchiveGitDir
Signed-off-by: Chris. Webster <chris@webstech.net>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
…cessary During the transition time when we switch from using a mirror of https://public-inbox.org/git for "reading the Git mailing list" to a mirror of https://lore.kernel.org/git/0, there will be a point when GitGitGadget's record still references a commit in the former repository while we want to access the latter. To help with that, assume that during the transition period there will still be a mirror of the former repository, and an environment variable `PUBLIC_INBOX_DIR` pointing to it. Then, find out the Message-ID of the commit, and find the corresponding commit in the new repository. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
| } | ||
| commitDiff = await git(["show", commit, "--"], | ||
| {workDir: this.mailArchiveGitDir}); | ||
| if (commitDiff.indexOf(`\n+${match[1]}\n`) >= 0) { |
There was a problem hiding this comment.
I am not advocating for the removal but is the + really needed for the regex or was it just left in when the replacement mode of updates was found?
There was a problem hiding this comment.
It is actually necessary: in the public-inbox.org repository, every mail was added as its own file, but in the lore.kernel.org one, every new mail replaces the previously-new mail in the file m. Therefore, if we look only for the Message-ID: <id>, we may very well find a commit that removes those contents, i.e. a commit that corresponds to the child of the commit we are looking for.
There was a problem hiding this comment.
So the \n+ should be \n\+, to actually include the literal + or the match at line 216 could have included the + - ie \n(\+Message-ID...).
There was a problem hiding this comment.
Oy. Oy, oy, oy. I got it right in line 216 and not here.
Good eyes! 👓
There was a problem hiding this comment.
Actually bad eyes. Sorry about this. The second check is using indexOf so it is not a regex. I was too focused on the search string and missed the method being used. Realized my error while you were making the update.
There was a problem hiding this comment.
Oh. Okay, I reverted this. I clearly need more sleep.
|
Sorry about not updating send-mail.test.ts. Don't think it was in master at the time but I should have remembered it. |
Oh, don't worry even 1ns about it. This is the reason why PR builds exist: to relieve us from that particular cognitive load. |
a99a000 to
e686598
Compare
Seems that public-inbox.org might go the same way as gmane.org went, or almost: a new archive has been set up at lore.kernel.org. See https://lore.kernel.org/git/20191120195556.GA25189@dcvr/t/#u (which is identical to https://public-inbox.org/git/20191120195556.GA25189@dcvr/t/#u, and has the message by the public-inbox.org maintainer).
A mirror was already set up at https://dev.azure.com/gitgitgadget/git/_git/lore-git?_a=history, and an Azure Pipeline to keep that mirror up to date: https://dev.azure.com/gitgitgadget/git/_build?definitionId=14&_a=summary.
These patches will (hopefully) take care of the rest.
This addresses #155