Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Require a project-specific config as repository variable #2002

Copy link
Copy link
@dscho

Description

@dscho
Issue body actions

In preparation for supporting projects other than Git, let's stop using the defaultConfig and enforce an explicit configuration on the specific gitgitgadget-workflows repository where the GitHub workflows are supposed to run.

The idea is to store those project-specific settings in the CONFIG repository variable, in JSON format, and consume it in all of the GitHub workflow runs in that repository.

Additionally, that same repository variable will also be retrieved and integrated into gitgitgadget-github-app whenever it gets deployed as Azure Function. That way, also the GitHub App won't use hard-coded project-specific settings any longer.

The current CONFIG looks like this, by the way:

{
  "repo": {
    "name": "git",
    "owner": "gitgitgadget",
    "baseOwner": "git",
    "testOwner": "dscho",
    "owners": [
      "gitgitgadget",
      "git",
      "dscho"
    ],
    "branches": [
      "maint",
      "seen"
    ],
    "closingBranches": [
      "maint",
      "master"
    ],
    "trackingBranches": [
      "maint",
      "seen",
      "master",
      "next"
    ],
    "maintainerBranch": "gitster",
    "host": "github.com"
  },
  "mailrepo": {
    "name": "git",
    "owner": "gitgitgadget",
    "branch": "master",
    "host": "lore.kernel.org",
    "url": "https://lore.kernel.org/git/",
    "public_inbox_epoch": 1,
    "mirrorURL": "https://github.com/gitgitgadget/git-mailing-list-mirror",
    "mirrorRef": "refs/heads/lore-1",
    "descriptiveName": "lore.kernel/git"
  },
  "mail": {
    "author": "GitGitGadget",
    "sender": "GitGitGadget",
    "smtpUser": "gitgitgadget@gmail.com",
    "smtpHost": "smtp.gmail.com"
  },
  "app": {
    "appID": 12836,
    "installationID": 195971,
    "name": "gitgitgadget",
    "displayName": "GitGitGadget",
    "altname": "gitgitgadget-git"
  },
  "lint": {
    "maxCommitsIgnore": [
      "https://github.com/gitgitgadget/git/pull/923"
    ],
    "maxCommits": 30
  },
  "user": {
    "allowUserAsLogin": false
  },
  "syncUpstreamBranches": [
    {
      "sourceRepo": "gitster/git",
      "targetRepo": "gitgitgadget/git",
      "sourceRefRegex": "^refs/heads/(maint-\\d|[a-z][a-z]/)"
    },
    {
      "sourceRepo": "j6t/git-gui",
      "targetRepo": "gitgitgadget/git",
      "targetRefNamespace": "git-gui/"
    }
  ]
}

You will note the addition of the mail.smtpUser and mail.smtpHost attributes, as well as the syncUpstreamBranches one.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.