mingw: avoid a buffer overrun in needs_hiding()#427
Closed
dscho wants to merge 1 commit intogitgitgadget:mastergitgitgadget/git:masterfrom
dscho:fix-needs-hiding-buffer-overrundscho/git:fix-needs-hiding-buffer-overrunCopy head branch name to clipboard
Closed
mingw: avoid a buffer overrun in needs_hiding()#427dscho wants to merge 1 commit intogitgitgadget:mastergitgitgadget/git:masterfrom dscho:fix-needs-hiding-buffer-overrundscho/git:fix-needs-hiding-buffer-overrunCopy head branch name to clipboard
needs_hiding()#427dscho wants to merge 1 commit intogitgitgadget:mastergitgitgadget/git:masterfrom
dscho:fix-needs-hiding-buffer-overrundscho/git:fix-needs-hiding-buffer-overrunCopy head branch name to clipboard
Conversation
When this function is passed a path with a trailing slash, it runs right over the end of that path. Let's fix this. Co-authored-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
/submit |
Member
Author
|
cc @SyntevoAlex |
|
Submitted as pull.427.git.1572012816.gitgitgadget@gmail.com |
|
This branch is now known as |
|
This patch series was integrated into pu via git@a617569. |
|
This patch series was integrated into next via git@d412109. |
|
This patch series was integrated into pu via git@d617a36. |
|
This patch series was integrated into pu via git@f2db52c. |
|
This patch series was integrated into next via git@f2db52c. |
|
This patch series was integrated into master via git@f2db52c. |
|
Closed via f2db52c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Unix, files are hidden from the output of
lsby default when their names start with a.. On Windows, there is an explicit flag that you need to set.It is quite uncommon, though, to hide all of the "dot files" on Windows, which is why Git hides only
.gitby default, and it has a setting to override this default (core.hideDotFiles).The code to determine whether that flag needs to be set for a given file had a buffer overrun, though, if the path that was passed into the function ended with a directory separator. This patch fixes this.
The original contribution by Alex is over at #414, and I worked with him to evolve it into the current version.
Cc: Alexandr Miloslavskiy alexandr.miloslavskiy@syntevo.com