[PoC] ci: Homebrew strikes again, let's try some workarounds on an older version#392
Closed
szeder wants to merge 1 commit intogitgitgadget:mastergitgitgadget/git:masterfrom
Closed
[PoC] ci: Homebrew strikes again, let's try some workarounds on an older version#392szeder wants to merge 1 commit intogitgitgadget:mastergitgitgadget/git:masterfrom
szeder wants to merge 1 commit intogitgitgadget:mastergitgitgadget/git:masterfrom
Conversation
Member
|
@szeder why two PRs with identical patches? |
Author
|
On Fri, Oct 11, 2019 at 02:49:43PM -0700, Johannes Schindelin wrote:
@szeder why two PRs with identical patches?
While the patches are identical, they are based on different commits.
I wanted to check whether `brew cask install perforce` works on Azure
Pipelines as well, in particular:
- without a previous `brew update`, i.e. on whatever Homebrew state
is present in the Azure Pipelines macOS images. This was checked
in that other PR.
- after a `brew update`, i.e. without commit f2f4715 (ci: don't
update Homebrew, 2019-07-03), hence this PR based on v2.22.0,
However, after having slept on it I finally realized what should
have been obvious from the beginning: the CI builds my PR merged
into master, i.e. with f2f4715 anyway... oh, well.
|
Member
... but the CI of course runs on the merge commit, which makes that difference rather pointless. |
Author
|
On Sun, Oct 13, 2019 at 03:21:41PM -0700, Johannes Schindelin wrote:
> While the patches are identical, they are based on different commits.
... but the CI of course runs on the merge commit, which makes that
difference rather pointless.
Yeah; as I said I realized that the next day...
|
Member
My common workaround is to use a different target branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just another small experiment.