Fallout from azure-pipelines-msvc#378
Closed
dscho wants to merge 1 commit intogitgitgadget:js/azure-pipelines-msvcgitgitgadget/git:js/azure-pipelines-msvcfrom
Closed
Fallout from azure-pipelines-msvc#378dscho wants to merge 1 commit intogitgitgadget:js/azure-pipelines-msvcgitgitgadget/git:js/azure-pipelines-msvcfrom
dscho wants to merge 1 commit intogitgitgadget:js/azure-pipelines-msvcgitgitgadget/git:js/azure-pipelines-msvcfrom
Conversation
We have just introduced the helper `index_pos_to_insert_pos()` to help avoiding underflows when returning `-1 - pos` for cases where we want to return an insert position, using the ones' complement (as `int`). As pointed out during the review of the patch series that introduced it, this helper wants to be accompanied by a helper that reverse that ones' complement, for clarity. This patch does exactly that. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
/submit |
|
Submitted as pull.378.git.gitgitgadget@gmail.com |
Member
Author
|
Seems that the goal of this patch won't get any support on the Git mailing list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a spill-over from my patch series that introduces support for building Git using Visual Studio in our CI builds, based on a suggestion by Johannes Sixt: complete the symmetry by adding a helper that does the opposite of
index_pos_to_insert_pos().I tried to be super inventive and came up with the name
insert_pos_to_index_pos()for said helper.Cc: Johannes Sixt j6t@kdbg.org