pkt-line: fix incorrect function declaration#192
Closed
dscho wants to merge 2 commits intogitgitgadget:mastergitgitgadget/git:masterfrom
dscho:fix-set_packet_header-signaturedscho/git:fix-set_packet_header-signatureCopy head branch name to clipboard
Closed
pkt-line: fix incorrect function declaration#192dscho wants to merge 2 commits intogitgitgadget:mastergitgitgadget/git:masterfrom dscho:fix-set_packet_header-signaturedscho/git:fix-set_packet_header-signatureCopy head branch name to clipboard
dscho wants to merge 2 commits intogitgitgadget:mastergitgitgadget/git:masterfrom
dscho:fix-set_packet_header-signaturedscho/git:fix-set_packet_header-signatureCopy head branch name to clipboard
Conversation
When this function was changed in a97d007 (remote-curl: use post_rpc() for protocol v2 also, 2019-02-21) from file-local to global, the declaration was incorrectly missing the `const` qualifier. Let's fix that. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
In f41179f (parse-options: avoid magic return codes, 2019-01-27), the signature of the low-level parse-opt callback function was changed to return an `enum`. And while the implementations were changed, one declaration was left unchanged, still claiming to return `int`. This can potentially lead to problems, as compilers are free to choose any integral type for an `enum` as long as it can represent all declared values. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
/submit |
|
Submitted as pull.192.git.gitgitgadget@gmail.com |
|
This branch is now known as |
|
This patch series was integrated into pu via git@d097692. |
|
This patch series was integrated into pu via git@ea68d60. |
|
This patch series was integrated into next via git@0feef07. |
|
This patch series was integrated into pu via git@7a09f5f. |
|
This patch series was integrated into next via git@7a09f5f. |
|
This patch series was integrated into master via git@7a09f5f. |
|
Closed via 7a09f5f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MS Visual C detected a mismatch between the declaration and the definition of
set_packet_header(): it is declared with its second parameter missing theconstattribute.It also detected a mismatch between the declaration and the definition of
parse_opt_unknown_cb().These problems must have been introduced very recently; I do not recall seeing them before today in any of Git for Windows' ever-green branches (i.e.
mastersemi-automatically rebased continously ontopu,next,masterandmaint).You could not have seen it in git.git's own Azure Pipeline, as Git for Windows' version already has support to build with MSVC (I plan to submit this directly after v2.22.0 is out).