Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Make abspath() aware of case-insensitive filesystems#104

Closed
dscho wants to merge 1 commit intogitgitgadget:mastergitgitgadget/git:masterfrom
dscho:case-insensitive-abspathdscho/git:case-insensitive-abspathCopy head branch name to clipboard
Closed

Make abspath() aware of case-insensitive filesystems#104
dscho wants to merge 1 commit intogitgitgadget:mastergitgitgadget/git:masterfrom
dscho:case-insensitive-abspathdscho/git:case-insensitive-abspathCopy head branch name to clipboard

Conversation

@dscho
Copy link
Member

@dscho dscho commented Dec 20, 2018 •
edited
Loading

It is completely legitimate these days to call git add with absolute paths. Of course, on a case-insensitive file system, users rightfully expect the argument to be handled case-insensitively, too. This patch makes it so.

Git for Windows carried this patch for over one and a half years already, I think it is time to get it into git.git.

Changes since v3:

  • Fixed the oneline (it talked about core.fileMode when it really wanted to talk about core.ignoreCase!).

Change since v2:

  • Replaced MINGW prerequisite in the test by CASE_INSENSITIVE_FS.
    v1 was sent out without a change by mistake. Sorry.

@dscho dscho mentioned this pull request Dec 20, 2018
Closed
35 tasks
@dscho
Copy link
Member Author

dscho commented Dec 21, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 21, 2018

Error: Ignoring PR with empty title and/or body

@dscho
Copy link
Member Author

dscho commented Dec 21, 2018

/submit

@gitgitgadget

This comment has been minimized.

Sign in to view
@gitgitgadget

This comment has been minimized.

Sign in to view
@gitgitgadget

This comment has been minimized.

Sign in to view
@gitgitgadget

This comment has been minimized.

Sign in to view
@gitgitgadget

This comment has been minimized.

Sign in to view
@gitgitgadget

This comment has been minimized.

Sign in to view
@gitgitgadget
Copy link

gitgitgadget bot commented Dec 21, 2018

Submitted as pull.104.git.gitgitgadget@gmail.com

@dscho dscho mentioned this pull request Dec 21, 2018
Merged
@dscho dscho force-pushed the case-insensitive-abspath branch from 4fb5de5 to 3eaec10 Compare December 24, 2018 19:13
@dscho dscho added the ready to submit Has commits that have not been submitted yet label Dec 24, 2018
@dscho
Copy link
Member Author

dscho commented Dec 24, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 24, 2018

Submitted as pull.104.v2.git.gitgitgadget@gmail.com

@dscho dscho force-pushed the case-insensitive-abspath branch from 3eaec10 to b935e11 Compare December 24, 2018 22:35
@dscho
Copy link
Member Author

dscho commented Dec 24, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 24, 2018

Submitted as pull.104.v3.git.gitgitgadget@gmail.com

@dscho
abspath_part_inside_repo: respect core.ignoreCase
3fb927f 
If the file system is case-insensitive, we really must be careful to
ignore differences in case only.

This fixes git-for-windows#735

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho force-pushed the case-insensitive-abspath branch from b935e11 to 3fb927f Compare January 18, 2019 12:59
@dscho
Copy link
Member Author

dscho commented Jan 18, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 18, 2019

Submitted as pull.104.v4.git.gitgitgadget@gmail.com

@dscho dscho removed the ready to submit Has commits that have not been submitted yet label Jan 18, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Jan 18, 2019

This branch is now known as js/abspath-part-inside-repo.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 18, 2019

This patch series was integrated into pu via git@bc1fa10.

@gitgitgadget gitgitgadget bot added the pu label Jan 18, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Jan 22, 2019

This patch series was integrated into pu via git@c85fd25.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 24, 2019

This patch series was integrated into pu via git@c88359e.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 28, 2019

This patch series was integrated into pu via git@0576c35.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 29, 2019

This patch series was integrated into pu via git@787787d.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 29, 2019

This patch series was integrated into next via git@ac64215.

@gitgitgadget gitgitgadget bot added the next label Jan 29, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Feb 4, 2019

This patch series was integrated into pu via git@6a97e2e.

@gitgitgadget
Copy link

gitgitgadget bot commented Feb 5, 2019

This patch series was integrated into pu via git@ff09c9e.

@gitgitgadget
Copy link

gitgitgadget bot commented Feb 5, 2019

This patch series was integrated into next via git@ff09c9e.

@gitgitgadget
Copy link

gitgitgadget bot commented Feb 5, 2019

This patch series was integrated into master via git@ff09c9e.

@gitgitgadget gitgitgadget bot added the master label Feb 5, 2019
@gitgitgadget gitgitgadget bot closed this Feb 5, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Feb 5, 2019

Closed via ff09c9e.

@dscho dscho deleted the case-insensitive-abspath branch February 6, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

master next pu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dscho
Morty Proxy This is a proxified and sanitized view of the page, visit original site.