Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2ed5352

Browse filesBrowse files
authored
Update contributors.md
1 parent 2e9d526 commit 2ed5352
Copy full SHA for 2ed5352

File tree

Expand file treeCollapse file tree

1 file changed

+16
-11
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+16
-11
lines changed

‎docs/contributors.md

Copy file name to clipboardExpand all lines: docs/contributors.md
+16-11Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,25 @@
33
### Checkin
44

55
- Do checkin source (src)
6-
- Do checkin build output (lib)
7-
- Do checkin runtime node_modules
8-
- Do not checkin devDependency node_modules (husky can help see below)
6+
- Do checkin a single index.js file after running `ncc`
7+
- Do not checkin node_modules
98

10-
### devDependencies
9+
### NCC
1110

12-
In order to handle correctly checking in node_modules without devDependencies, we run [Husky](https://github.com/typicode/husky) before each commit.
13-
This step ensures that formatting and checkin rules are followed and that devDependencies are excluded. To make sure Husky runs correctly, please use the following workflow:
11+
In order to avoid uploading `node_modules` to the repository, we use [zeit/ncc](https://github.com/zeit/ncc) to create a single `index.js` file that gets saved in `dist/`.
1412

13+
### Developing
14+
15+
If you're developing locally you can run
1516
```
16-
npm install # installs all devDependencies including Husky
17-
git add abc.ext # Add the files you've changed. This should include files in src, lib, and node_modules (see above)
18-
git commit -m "Informative commit message" # Commit. This will run Husky
17+
npm install
18+
tsc
19+
ncc build
1920
```
21+
An files generated using `tsc` will be added to `lib/` however those files also are not uploaded to the repository and are exluded using `.gitignore`.
22+
23+
During the commit step, Husky will take care of formatting all files with [Prettier](https://github.com/prettier/prettier)
24+
25+
### Testing
2026

21-
During the commit step, Husky will take care of formatting all files with [Prettier](https://github.com/prettier/prettier) as well as pruning out devDependencies using `npm prune --production`.
22-
It will also make sure these changes are appropriately included in your commit (no further work is needed)
27+
We ask that you include a link to a succesfull run that utilizes the changes you are working on. For example, if your changes are in the branch `newAwesomeFeature`, then show an example run that uses `setup-python@newAwesomeFeature`. This will help speed up testing and help us confirm that there are no breaking changes or bugs.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.