Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add better facility to resume / skip hooks #15

Copy link
Copy link
@avar

Description

@avar
Issue body actions

We're increasingly reliant on hooks but our top-level command-line facility to interact with them pre-dates the phase hook support. We just have a --skip_hooks option which skips the run of all hooks. Things that we'd also like, in no particular order:

Sequencing support, the ability to continue after we fail after having run n/x hooks

Say we're running 2x pre-sync hooks and the sync hook fails, currently you have to re-run the path of the sync hook, but you have no idea if there were any post-sync hooks or anything else that needs to run.

Whenever we have a sequence of hooks we're running we should write that sequence to .git/deploy/sequencer, then you could do git-deploy --continue, git-deploy --abort etc. See ./Documentation/sequencer.txt in git.git for generic support for this (which we may or may not be able to use).

Continuing would try to re-run the failing hook (e.g. a broken sync hook), you could run that in a loop until it worked, and it would make sure to run the remaining hooks (if any), and finish appropriately.

Ability to skip specific hooks and to run new hooks

Now that we have phase hooks maybe this should be something like this:

# like --skip_hooks now, we could alias that to this:
--skip-hook=*
 # skip all log hooks
 --skip-hook=log.*
 # skip several types of hooks
 --skip-hook=sync.* --skip-hook=log.*
 # skip a specific hook
 --skip-hook=log.*jabber*
 # or just reply on it matching against the right thing out of all the hooks
 --skip-hook=*jabber*

While we're at it we could also include --add-hook, if we did that we could completely emulate the current hook support with command-line switches:

git-deploy --add-hook=start./some/path/000.start.pl start

Or something like that.

Reactions are currently unavailable

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.