banned.h: Fix copy-paste error#635
Closed
underyx wants to merge 1 commit intogit:mastergit/git:masterfrom
Closed
Conversation
Author
|
Superseded by gitgitgadget#322 |
Abhra303
added a commit
to Abhra303/git
that referenced
this pull request
Sep 26, 2021
issue no git#635 in the gitgitgadget/git repo has a breif description about the violation of error message style convention. These violations are - 1) Do not end error messages with a full stop. 2) Do not capitalize ("unable to open %s", not "Unable to open %s") 3) Say what the error is first ("cannot open %s", not "%s: cannot open") This fixes all possible violations of error messages. Most of these violations were related to 1st and 2nd point of the error msg style convention. But some were violating the 3rd point. In that case, I tried to change the msg little bit so that they follow the convention (with the same meaning). Signed-off-by: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Abhra303
added a commit
to Abhra303/git
that referenced
this pull request
Oct 17, 2021
issue no git#635 in the gitgitgadget/git repo has a breif description about the violation of error message style convention. These violations are - 1) Do not end error messages with a full stop. 2) Do not capitalize ("unable to open %s", not "Unable to open %s") 3) Say what the error is first ("cannot open %s", not "%s: cannot open") This fixes all possible violations of error messages. Most of these violations were related to 1st and 2nd point of the error msg style convention. But some were violating the 3rd point. In that case, I tried to change the msg little bit so that they follow the convention (with the same meaning). Signed-off-by: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Abhra303
added a commit
to Abhra303/git
that referenced
this pull request
Oct 24, 2021
Issue no git#635 in the gitgitgadget/git repo has a breif description about the violation of error message style convention. These violations are - 1) Do not end error messages with a full stop. 2) Do not capitalize ("unable to open %s", not "Unable to open %s") 3) Say what the error is first ("cannot open %s", not "%s: cannot open") This commit is the first commit to amend those error strings. It covers files in the root directory that start with letter 'a'. This is a small patch to start as suggested. There will be more patches to cover all files and directories. One thing to note that I didn't change any .po files as there is a doubt whether those are good to change or not. Signed-off-by: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Abhra303
added a commit
to Abhra303/git
that referenced
this pull request
Oct 25, 2021
Issue no git#635 in the gitgitgadget/git repo has a brief description about the violation of error message style convention. These violations are - 1) Do not end error messages with a full stop. 2) Do not capitalize ("unable to open %s", not "Unable to open %s") 3) Say what the error is first ("cannot open %s", not "%s: cannot open") This commit is the first commit to amend those error strings. It covers files in the root directory that start with letter 'a'. This is a small patch to start as suggested. There will be more patches to cover all files and directories. One thing to note that I didn't change any .po file as there is a doubt whether those are good to change or not. Signed-off-by: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Abhra303
added a commit
to Abhra303/git
that referenced
this pull request
Oct 25, 2021
Issue no git#635 in the gitgitgadget/git repo has a brief description about the violation of error message style convention. These violations are - 1) Do not end error messages with a full stop. 2) Do not capitalize ("unable to open %s", not "Unable to open %s") 3) Say what the error is first ("cannot open %s", not "%s: cannot open") This commit is the first commit to amend those error strings. It covers files in the root directory that start with letter 'a'. This is a small patch to start as suggested. There will be more patches to cover all files and directories. One thing to note that I didn't change any .po file as there is a doubt whether those are good to change or not. Signed-off-by: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list (git@vger.kernel.org) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.
Please read the "guidelines for contributing" linked above!