Travis CI: Lint for Python syntax errors and undefined names#611
Travis CI: Lint for Python syntax errors and undefined names#611cclauss wants to merge 1 commit intogit:mastergit/git:masterfrom
Conversation
|
@cclauss thank you! The remaining Travis issue is a known one, and I think it will be addressed at some stage via the Git mailing list. Back to your patches: you are probably a lot more familiar with Python than I am... from my side, the code changes look good. Would you mind adding a bit of information to the commit messages (see e.g. 2000ac9 for an example of a commit message in Please make sure that your commit message focuses on answering the question "why?" more than on "how?", and that it wraps at <= 76 columns per line. Finally send the patch to the mailing list for review. You can use GitGitGadget, submitGit or send it manually. |
Several things were changed between Python 2 and Python 3. There are a few Python 3 incompatibilities to work on. Here we are making changes to make the code run on both Py2 and Py3. We are doing this because the end of life of Python 2 is in 167 days. We are using print() function because legacy print statements are syntax errors on Py3. reduce() was moved in Python 3 and raw_input() was removed so we make changes to avoid NameErrors being raised at runtime. We are also putting flake8 lint tests in place on Travis CI to avoid any backsliding on future pull requests. Signed-off-by: cclauss <cclauss@me.com>
|
@cclauss gentle ping? |
|
Ah. This PR is superseded by gitgitgadget#290. |
There are a few Python 3 incompatibilities to work on.
Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list (git@vger.kernel.org) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.
Please read the "guidelines for contributing" linked above!