t1308-config-set: fix a test that has a typo#451
Closed
tanayabh wants to merge 1 commit intogit:mastergit/git:masterfrom
Closed
t1308-config-set: fix a test that has a typo#451tanayabh wants to merge 1 commit intogit:mastergit/git:masterfrom
tanayabh wants to merge 1 commit intogit:mastergit/git:masterfrom
Conversation
Change test 'find value_list for a key from a configset' to compare result with 'expect' instead of 'except' which was a typo. Change the test call from 'configset_get_value' to 'configset_get_value_multi' since the test expects a list of values instead of a single value. Signed-off-by: Tanay Abhra <tanayabh@gmail.com>
Member
|
@tanayabh wow, this is a really old PR and the bug is still in Git! Would you mind rebasing this patch on top of |
Member
|
@tanayabh ping? |
1 similar comment
Member
|
@tanayabh ping? |
Member
|
@tanayabh gentle ping? |
dscho
pushed a commit
to dscho/git
that referenced
this pull request
Oct 10, 2019
Change test 'find value_list for a key from a configset' to redirect the result to 'expect' instead of 'except' which was a typo. With this change, the test case actually fails because it uses `configset_get_value`. Clearly, this was intended to be `configset_get_value_multi` since the test expects a list of values instead of a single value, so let's fix that, too. Originally contributed as git#451. Signed-off-by: Tanay Abhra <tanayabh@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
|
Superseded by gitgitgadget#387. |
derrickstolee
added a commit
to derrickstolee/git
that referenced
this pull request
Oct 21, 2021
…ly once Users are noticing slowdowns with things checking GIT_VIRTUALFILESYSTEM_TEST environment multiple times. This is likely due to checking for the virtual filesystem while engaging with the FS Monitor feature. Use a `static` variable to avoid initializing these globals multiple times. Resolves git#450.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change test 'find value_list for a key from a configset' to compare
result with 'expect' instead of 'except' which was a typo. Change the
test call from 'configset_get_value' to 'configset_get_value_multi'
since the test expects a list of values instead of a single value.
Signed-off-by: Tanay Abhra tanayabh@gmail.com