Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b10ecd0

Browse filesBrowse files
authored
Remove broken row_seek() and row_tell() (PyMySQL#220)
They are broken from long ago and making them safe is difficult. So remove them rather than fix.
1 parent d65e10e commit b10ecd0
Copy full SHA for b10ecd0

File tree

Expand file treeCollapse file tree

1 file changed

+0
-52
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-52
lines changed

‎_mysql.c

Copy file name to clipboardExpand all lines: _mysql.c
-52Lines changed: 0 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -2166,46 +2166,6 @@ _mysql_ResultObject_data_seek(
21662166
return Py_None;
21672167
}
21682168

2169-
static char _mysql_ResultObject_row_seek__doc__[] =
2170-
"row_seek(n) -- seek by offset n rows of result set";
2171-
static PyObject *
2172-
_mysql_ResultObject_row_seek(
2173-
_mysql_ResultObject *self,
2174-
PyObject *args)
2175-
{
2176-
int offset;
2177-
MYSQL_ROW_OFFSET r;
2178-
if (!PyArg_ParseTuple(args, "i:row_seek", &offset)) return NULL;
2179-
check_result_connection(self);
2180-
if (self->use) {
2181-
PyErr_SetString(_mysql_ProgrammingError,
2182-
"cannot be used with connection.use_result()");
2183-
return NULL;
2184-
}
2185-
r = mysql_row_tell(self->result);
2186-
mysql_row_seek(self->result, r+offset);
2187-
Py_INCREF(Py_None);
2188-
return Py_None;
2189-
}
2190-
2191-
static char _mysql_ResultObject_row_tell__doc__[] =
2192-
"row_tell() -- return the current row number of the result set.";
2193-
static PyObject *
2194-
_mysql_ResultObject_row_tell(
2195-
_mysql_ResultObject *self,
2196-
PyObject *noargs)
2197-
{
2198-
MYSQL_ROW_OFFSET r;
2199-
check_result_connection(self);
2200-
if (self->use) {
2201-
PyErr_SetString(_mysql_ProgrammingError,
2202-
"cannot be used with connection.use_result()");
2203-
return NULL;
2204-
}
2205-
r = mysql_row_tell(self->result);
2206-
return PyInt_FromLong(r-self->result->data->data);
2207-
}
2208-
22092169
static void
22102170
_mysql_ResultObject_dealloc(
22112171
_mysql_ResultObject *self)
@@ -2504,18 +2464,6 @@ static PyMethodDef _mysql_ResultObject_methods[] = {
25042464
METH_VARARGS,
25052465
_mysql_ResultObject_data_seek__doc__
25062466
},
2507-
{
2508-
"row_seek",
2509-
(PyCFunction)_mysql_ResultObject_row_seek,
2510-
METH_VARARGS,
2511-
_mysql_ResultObject_row_seek__doc__
2512-
},
2513-
{
2514-
"row_tell",
2515-
(PyCFunction)_mysql_ResultObject_row_tell,
2516-
METH_NOARGS,
2517-
_mysql_ResultObject_row_tell__doc__
2518-
},
25192467
{
25202468
"describe",
25212469
(PyCFunction)_mysql_ResultObject_describe,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.