This repository was archived by the owner on Jul 1, 2020. It is now read-only.
fix Cannot read property 'indexOf' of undefined#163
Merged
ghiscoding merged 2 commits intoghiscoding:masterghiscoding/angular-validation:masterfrom Aug 16, 2017
noherczeg:patch-2Copy head branch name to clipboard
Merged
fix Cannot read property 'indexOf' of undefined#163ghiscoding merged 2 commits intoghiscoding:masterghiscoding/angular-validation:masterfrom noherczeg:patch-2Copy head branch name to clipboard
ghiscoding merged 2 commits intoghiscoding:masterghiscoding/angular-validation:masterfrom
noherczeg:patch-2Copy head branch name to clipboard
Conversation
The `.rules` property could be an empty string in which case the code dies because it uses `self.validatorAttrs.validation` which could be undefined, therefore the `.indexOf` check fails. This fixes TypeError: Cannot read property 'indexOf' of undefined.
Owner
|
Thanks for the fix, I will merge and run the tests. It's actually cool, I didn't know we could write this way to deal with double safe, thanks for the tip :) |
Contributor
Author
|
Sadly I couldn't use this lib because I couldn't make it to work with kendo components + getterSetters :( Hopefully my fixes are worthy anyway. |
ghiscoding
added a commit
that referenced
this pull request
Aug 17, 2017
Owner
|
All merged and release, thanks for the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.rulesproperty could be an empty string in which case the code dies because it usesself.validatorAttrs.validationwhich could be undefined, therefore the.indexOfcheck fails.This fixes TypeError: Cannot read property 'indexOf' of undefined.