Add support for record subtype declarations (constraints) #2902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the new types in this commit into pyGHDL, which it depends on. Record subtypes should have their constraits parsed now, like so, (output from
dom.py pretty):I was not sure how to use RecordConstraint and ArrayConstraint, since the constraints could be Symbol -> Expression?
This is my first PR, it is possible I have committed some devops embarrassments. In particular I did my work on master and only now realized I was supposed to have created a feature branch first. I used --force-with-lease to replace some commits accidentally containing dot folder detritus. Let me know if any of this needs reconciled.