graph : fix geglu #14077
Merged
graph : fix geglu #14077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggml-ci
CISC
reviewed
Jun 9, 2025
Comment on lines
+666
to
+668
| // TODO: these conts should not be needed | ||
| ggml_tensor * x0 = ggml_cont(ctx0, ggml_view_2d(ctx0, cur, split_point, cur->ne[1], cur->nb[1], 0)); | ||
| ggml_tensor * x1 = ggml_cont(ctx0, ggml_view_2d(ctx0, cur, split_point, cur->ne[1], cur->nb[1], split_point * ggml_element_size(cur))); |
There was a problem hiding this comment.
Can we move this operation earlier and have it for both SWIGLU/GEGLU to keep things DRY?
There was a problem hiding this comment.
Yes, though either way is OK. If we repeat more than 2 times, then we can DRY it.
I would first look into removing the conts btw.
There was a problem hiding this comment.
This seems safe to me (removing ggml_cont), at least it works fine here, what would be the scenario when it's not?
There was a problem hiding this comment.
It is correct, I just think the conts should not be necessary and introduce overhead.
CISC
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cont #14074