Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

convert : support chat_template.json #12460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

CISC
Copy link
Collaborator

@CISC CISC commented Mar 19, 2025

Useful for f.ex. mistralai/Mistral-Small-3.1-24B-Instruct-2503 that has no chat template in tokenizer_config.json.

@github-actions github-actions bot added the python python script changes label Mar 19, 2025
@CISC CISC requested a review from compilade March 19, 2025 04:35
@ngxson
Copy link
Collaborator

ngxson commented Mar 19, 2025

Ok this is a bit surprise, I heard from my coworker at HF said that chat_template.json is used by Processor class, and it is a bit confusing indeed.

@ngxson ngxson merged commit a686171 into ggml-org:master Mar 19, 2025
4 checks passed
@CISC CISC deleted the convert-chat-template-json branch March 19, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python python script changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.