Issues while enabling MMA support on AIX machines #12241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taronaeo
reviewed
Mar 7, 2025
ggml/src/ggml-cpu/CMakeLists.txt
Outdated
Comment on lines
292
to
293
| if(${CMAKE_SYSTEM_PROCESSOR} MATCHES "ppc64") | ||
| execute_process(COMMAND bash -c "grep POWER /proc/cpuinfo | head -n 1" OUTPUT_VARIABLE POWER10_M) |
There was a problem hiding this comment.
I believe you can do this without forking an additional process. Refer to the implementation I did for s390x here: https://github.com/ggml-org/llama.cpp/blob/master/ggml/src/ggml-cpu/CMakeLists.txt#L319-L320
Hello from IBM Technologies Singapore! :)
There was a problem hiding this comment.
Hi Aaron, thanks for the suggestion.
I have updated it now. :)
ee63d7f to
fe17b9e
Compare
a1aa6c3 to
0e7e69f
Compare
0a5ffd4 to
63f6e36
Compare
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12240