Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

tool-call: support Command R7B (+ return tool_plan "thoughts" in API) #11585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 2, 2025
Merged

tool-call: support Command R7B (+ return tool_plan "thoughts" in API) #11585

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e44a8eb
`tool-call`: Command R7B (w/ tool_plan return), preserved_tokens & te…
Feb 2, 2025
548ac5a
fix test-chat
Feb 2, 2025
a28d9be
rm msg.thoughts (that's for later / R1)
Feb 2, 2025
5fd28b3
use set::find
Feb 2, 2025
3a37ae4
comment / warn about preserved tokens not being single tokens
Feb 2, 2025
a278637
make multi token not preserved warning more actionable
Feb 2, 2025
4a5b654
bump multi token not preserved log to warning
Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test-chat
  • Loading branch information
ochafik committed Feb 2, 2025
commit 548ac5a4c0a1135a17d6f5a941eaf4c79fb7c17e
10 changes: 2 additions & 8 deletions 10 tests/test-chat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,22 +392,16 @@ static void test_template_output_parsers() {
inputs_tools_builtin.tools.push_back(python_tool);

{
// Not supported yet
const common_chat_template tmpl(read_file("models/templates/CohereForAI-c4ai-command-r-plus-tool_use.jinja"), "<s>", "</s>");
assert_equals(COMMON_CHAT_FORMAT_GENERIC, common_chat_params_init(tmpl, inputs_no_tools).format);
assert_equals(COMMON_CHAT_FORMAT_GENERIC, common_chat_params_init(tmpl, inputs_tools).format);
}
{
const common_chat_template tmpl(read_file("models/templates/CohereForAI-c4ai-command-r7b-12-2024-tool_use.jinja"), "<s>", "</s>");
std::vector<std::string> end_tokens{ "<|END_OF_TURN_TOKEN|>" };

assert_equals(COMMON_CHAT_FORMAT_CONTENT_ONLY, common_chat_params_init(tmpl, inputs_no_tools).format);
assert_equals(COMMON_CHAT_FORMAT_COMMAND_R7B, common_chat_params_init(tmpl, inputs_tools).format);
assert_equals(
COMMON_CHAT_FORMAT_COMMAND_R7B,
common_chat_params_init(
common_chat_template(read_file("models/templates/CohereForAI-c4ai-command-r-plus-tool_use.jinja"),
"<s>", "</s>"),
inputs_tools)
.format);

test_template(tmpl, end_tokens, tool_call_plan_message_with_idx, tools,
"<|START_THINKING|>I'm not so sure<|END_THINKING|>"
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.