Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

server: remove std::terminate() in http thread #18289

Copy link
Copy link
@ngxson

Description

@ngxson
Issue body actions

Remove std::terminate() in those 2 places:

std::terminate(); // we cannot return here since the caller is HTTP code

std::terminate(); // we cannot return here since the caller is HTTP code

They were there because we cannot return to the caller, which may cause deadlock.

The more appropriate solution here is to throw an specific exception that will be catched by ex_wrapper(), which will terminate the thread

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.