-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Open
Description
Remove std::terminate() in those 2 places:
llama.cpp/tools/server/server-queue.cpp
Line 257 in 6ce863c
| std::terminate(); // we cannot return here since the caller is HTTP code |
llama.cpp/tools/server/server-queue.cpp
Line 289 in 6ce863c
| std::terminate(); // we cannot return here since the caller is HTTP code |
They were there because we cannot return to the caller, which may cause deadlock.
The more appropriate solution here is to throw an specific exception that will be catched by ex_wrapper(), which will terminate the thread
Metadata
Metadata
Assignees
Labels
No labels