Upgrade to latest wgpu#441
Upgrade to latest wgpu#441eliemichel wants to merge 10 commits intogfx-rs:trunkgfx-rs/wgpu-native:trunkfrom eliemichel:eliemichel/2024-10-14-upgrade-wgpueliemichel/wgpu-native:eliemichel/2024-10-14-upgrade-wgpuCopy head branch name to clipboard
Conversation
|
23.0 is out, so the git hashes can be a proper version again :) |
|
Quick request. I see you've added ComputePassSetPushConstants. Would it be difficult to also add RenderEncoderSetPutConstants. Not that I need it, but it seems that if we have two. we should have the complete set. Thanks |
Done!
Not the point of this PR, which only mechanically upgrade the underlying wgpu, you should open a dedicated issue ;) |
|
I was about to send you an email to cancel that previous request. It
turns out that RenderBundleSetPushConstants is completely broken, and has
probably never been used. I'm in the middle of creating a bug report.
…On Mon, Nov 11, 2024 at 11:44 PM Elie Michel ***@***.***> wrote:
23.0 is out, so the git hashes can be a proper version again :)
Done!
Quick request. I see you've added ComputePassSetPushConstants.
Not the point of this PR, which only mechanically upgrade the underlying
wgpu, you should open a dedicated issue ;)
—
Reply to this email directly, view it on GitHub
<#441 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC2LIP265GQH5RJKW23R3L2AGWVHAVCNFSM6AAAAABP33FGCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZHAYDQNJUGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
almarklein
left a comment
There was a problem hiding this comment.
This looks good to me. @rajveermalviya do you have time to review this too? I'm not confident enough with Rust to judge most changes.
|
I think we can close this one; the changes have been merged on #455 |
This PR builds upon #427 and adapts it to recent changes in
wgpu.My overall goal is to adapt to gfx-rs/wgpu#6360 so that we can finally implement
WGPUFuture.