Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Oct 14, 2025

Updates the bundle script in React Native to match the one from the docs and support the changes done here: getsentry/sentry-react-native#5221

@alwx alwx requested review from Lms24 and antonis October 14, 2025 08:29
@alwx alwx force-pushed the alwx/improvement/updated-bundle-script branch from 853870c to 66ce64d Compare October 14, 2025 08:43
@alwx alwx removed request for Lms24 and antonis October 14, 2025 08:45
@alwx alwx marked this pull request as draft October 14, 2025 08:45
@alwx alwx requested review from Lms24 and antonis October 14, 2025 09:00
@alwx alwx marked this pull request as ready for review October 14, 2025 09:00
@alwx alwx force-pushed the alwx/improvement/updated-bundle-script branch 2 times, most recently from b63a160 to cdb374e Compare October 14, 2025 09:01
@alwx alwx force-pushed the alwx/improvement/updated-bundle-script branch from cdb374e to 415dd5b Compare October 14, 2025 09:03
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.45%. Comparing base (116aede) to head (695f259).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/react-native/react-native-wizard.ts 0.00% 2 Missing ⚠️
src/react-native/xcode.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
- Coverage   32.56%   32.45%   -0.12%     
==========================================
  Files         133      133              
  Lines       15702    15689      -13     
  Branches     1112     1105       -7     
==========================================
- Hits         5114     5092      -22     
- Misses      10571    10580       +9     
  Partials       17       17              
Flag Coverage Δ
unit-tests 32.45% <60.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM and worked as expected on my local tests with a fresh RN 0.82.0 project (test error)🚀

npx @react-native-community/cli@latest init AwesomeProject82test
npx ~/git/sentry-wizard -i reactNative

Thank you for cleaning up the version specific patch 🙇

@alwx alwx enabled auto-merge (squash) October 14, 2025 10:33
@alwx alwx merged commit 17aacef into master Oct 14, 2025
63 of 75 checks passed
@alwx alwx deleted the alwx/improvement/updated-bundle-script branch October 14, 2025 10:38
@antonis
Copy link
Contributor

antonis commented Oct 14, 2025

@Lms24 We'll push an update for a failing check in a follow-up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.