-
-
Notifications
You must be signed in to change notification settings - Fork 353
feat(session-replay): Set enableSessionReplayInUnreliableEnvironment on iOS #5268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(session-replay): Set enableSessionReplayInUnreliableEnvironment on iOS #5268
Conversation
|
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3fa43ad | 392.00 ms | 405.38 ms | 13.38 ms |
ba483fc | 407.51 ms | 398.52 ms | -8.99 ms |
a7ec8e0+dirty | 416.64 ms | 442.94 ms | 26.30 ms |
f9bd7d3 | 403.74 ms | 385.54 ms | -18.20 ms |
8b9ad38 | 402.58 ms | 399.44 ms | -3.15 ms |
6c67a16 | 442.07 ms | 454.91 ms | 12.84 ms |
19a2edb+dirty | 407.57 ms | 458.70 ms | 51.12 ms |
f139dae | 415.36 ms | 400.73 ms | -14.63 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3fa43ad | 17.75 MiB | 19.68 MiB | 1.94 MiB |
ba483fc | 17.75 MiB | 20.15 MiB | 2.40 MiB |
a7ec8e0+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
f9bd7d3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
8b9ad38 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
6c67a16 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
19a2edb+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
f139dae | 17.75 MiB | 20.15 MiB | 2.40 MiB |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f139dae+dirty | 383.66 ms | 389.28 ms | 5.62 ms |
ba483fc+dirty | 432.91 ms | 454.14 ms | 21.23 ms |
a7ec8e0+dirty | 342.33 ms | 377.29 ms | 34.96 ms |
3fa43ad+dirty | 391.11 ms | 426.39 ms | 35.28 ms |
6c67a16+dirty | 408.86 ms | 440.96 ms | 32.10 ms |
f9bd7d3+dirty | 403.83 ms | 442.76 ms | 38.92 ms |
8b9ad38+dirty | 352.09 ms | 428.29 ms | 76.20 ms |
19a2edb+dirty | 445.10 ms | 428.43 ms | -16.67 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f139dae+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
ba483fc+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
a7ec8e0+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
3fa43ad+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
6c67a16+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
f9bd7d3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
8b9ad38+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
19a2edb+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8b9ad38+dirty | 1233.63 ms | 1236.43 ms | 2.79 ms |
6c67a16+dirty | 1218.27 ms | 1224.22 ms | 5.96 ms |
a7ec8e0+dirty | 1242.49 ms | 1223.02 ms | -19.47 ms |
f9bd7d3+dirty | 1207.15 ms | 1216.72 ms | 9.57 ms |
3fa43ad+dirty | 1223.29 ms | 1232.41 ms | 9.12 ms |
19a2edb+dirty | 1231.82 ms | 1237.24 ms | 5.42 ms |
f139dae+dirty | 1220.86 ms | 1233.21 ms | 12.35 ms |
ba483fc+dirty | 1211.24 ms | 1220.49 ms | 9.24 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8b9ad38+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
6c67a16+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
a7ec8e0+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
f9bd7d3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
3fa43ad+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
19a2edb+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
f139dae+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
ba483fc+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8b9ad38+dirty | 1218.50 ms | 1213.23 ms | -5.27 ms |
6c67a16+dirty | 1220.52 ms | 1223.47 ms | 2.95 ms |
a7ec8e0+dirty | 1227.12 ms | 1245.33 ms | 18.20 ms |
f9bd7d3+dirty | 1224.46 ms | 1237.04 ms | 12.58 ms |
3fa43ad+dirty | 1227.35 ms | 1234.63 ms | 7.29 ms |
19a2edb+dirty | 1235.08 ms | 1239.51 ms | 4.43 ms |
f139dae+dirty | 1213.82 ms | 1215.87 ms | 2.05 ms |
ba483fc+dirty | 1203.07 ms | 1213.62 ms | 10.55 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8b9ad38+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
6c67a16+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
a7ec8e0+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
f9bd7d3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
3fa43ad+dirty | 3.19 MiB | 4.53 MiB | 1.34 MiB |
19a2edb+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
f139dae+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
ba483fc+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
@philprime Adding you as a reviewer on this one for awareness and potential feedback 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, other than LGTM
CHANGELOG.md
Outdated
- Overrides the default Cocoa SDK behavior that disables Session Replay on iOS 26.0 ([#5268](https://github.com/getsentry/sentry-react-native/pull/5268)) | ||
- If you are using Apple's Liquid Glass we recommend that you disable Session Replay on iOS to prevent potential PII leaks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m
: We should add a reference to the warning in https://github.com/getsentry/sentry-cocoa/releases/tag/8.57.0 so that users can get the full context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Added with 6b6b75b
[RNSentryReplay updateOptions:mutableOptions]; | ||
BOOL isSessionReplayEnabled = [RNSentryReplay updateOptions:mutableOptions]; | ||
#else | ||
BOOL isSessionReplayEnabled = NO; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l
: There might be value in adding a comment here for future maintainers to understand why it defaults to NO
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added with 46986c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* chore: update scripts/update-cocoa.sh to 8.57.0 * feat(session-replay): Set enableSessionReplayInUnreliableEnvironment on iOS (#5268) * feat(session-replay): Set enableSessionReplayInUnreliableEnvironment on iOS * Adds tests * Add changelog * fix disabled condition * Add comment for targets that do not support session replay * Add reference to cocoa release note --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
📢 Type of change
📜 Description
Sets
enableSessionReplayInUnreliableEnvironment
totrue
when session replay is enabled. This overrides the default iOS behavior in iOS 26 (from 8.57.0) that has SR off to prevent potential PII leaks.💡 Motivation and Context
Fixes #5264
💚 How did you test it?
Manually, Unit tests
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps