Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

krystofwoldrich
Copy link
Contributor

📢 Type of change

  • New feature
  • Refactoring

📜 Description

This PR is an alternative to #4910 implementing automatic detection of the application name and version to form a Sentry Release for Expo Web.

The automatic release enabled the Expo Web to get automatic Session and Replays, without warnings and errors about missing release.

This PR uses the Expo Config retrieval from the previous PR, https://github.com/getsentry/sentry-react-native/pull/4910/files#diff-046edcb66effc01d1cb5c9b13fda59fe16c771580a217bc3f972f2f8ce576a03R38.

But implements a different way to inject the release into the JS bundle. It creates a new Virtual JS Module which adds the release value to the global vars.

This module is only added for web bundles, both dev and release.

💡 Motivation and Context

💚 How did you test it?

unit tests + sample app

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested both with a release and debug builds and worked as expected.
Screenshot 2025-07-03 at 5 46 43 PM

Awesome work @krystofwoldrich 🏅
Thank you the time to give feedback and contribute with this PR 🙇

CHANGELOG.md Outdated Show resolved Hide resolved
@antonis antonis merged commit 1667b2b into getsentry:v7 Jul 4, 2025
77 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.