You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follow-up on #4892 removes deprecated appOwnership from the environment utils.
This PR proposes a detection of the Expo Go app based on the presence of the ExpoGo module. This assumption is based on the following comment and testing a sample app in Expo Go and dev client apps.
馃挕 Motivation and Context
馃挌 How did you test it?
馃摑 Checklist
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
Hi @pchalupa,
the changes make sense, and it's good to align with the Expo implementation on the Expo Go detection.
@antonis My only concern is that ExpoGo module is not available in Expo SDK 49, which is officially not supported by the Sentry RN SDK v6, but there are no know issues at the moment.
Since we are currently working on a Sentry RN SDK v7, it's up to discussion, but I think this would be a good addition to it.
My only concern is that ExpoGo module is not available in Expo SDK 49, which is officially not supported by the Sentry RN SDK v6, but there are no know issues at the moment.
Since we are currently working on a Sentry RN SDK v7, it's up to discussion, but I think this would be a good addition to it.
Good point @krystofwoldrich 馃憤 Yes, let's iterate on this in the context of v7.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃摙 Type of change
馃摐 Description
This follow-up on #4892 removes deprecated appOwnership from the environment utils.
This PR proposes a detection of the Expo Go app based on the presence of the ExpoGo module. This assumption is based on the following comment and testing a sample app in Expo Go and dev client apps.
馃挕 Motivation and Context
馃挌 How did you test it?
馃摑 Checklist
sendDefaultPIIis enabled馃敭 Next steps