(feat-V7) Log Tracing #4827
(feat-V7) Log Tracing #4827
Conversation
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746 | 399.51 ms | 429.09 ms | 29.58 ms |
| 472960b | 418.84 ms | 405.38 ms | -13.46 ms |
| f870f2d | 444.67 ms | 449.62 ms | 4.95 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746 | 17.75 MiB | 19.58 MiB | 1.83 MiB |
| 472960b | 17.75 MiB | 19.58 MiB | 1.83 MiB |
| f870f2d | 17.75 MiB | 19.58 MiB | 1.83 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746+dirty | 1215.12 ms | 1222.31 ms | 7.18 ms |
| 472960b+dirty | 1213.96 ms | 1222.58 ms | 8.62 ms |
| f870f2d+dirty | 1227.18 ms | 1232.30 ms | 5.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 472960b+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
| f870f2d+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746+dirty | 1227.65 ms | 1228.81 ms | 1.16 ms |
| 472960b+dirty | 1243.67 ms | 1233.57 ms | -10.11 ms |
| f870f2d+dirty | 1230.08 ms | 1238.88 ms | 8.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c99746+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| 472960b+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| f870f2d+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
|
|
|
build errors will be fixed on #4860 |
…into lz/v7-test-logs
…-react-native into lz/v7-test-logs
| bytesPayload = itemPayload; | ||
| } else { | ||
| bytesContentType = 'application/json'; | ||
| bytesContentType = 'application/vnd.sentry.items.log+json'; |
There was a problem hiding this comment.
Should we use the new content type for all requests or only the ones that contain logs? @krystofwoldrich @kahest
This can create a break changes on self -hosted, and I am not sure which version has support for logging.
There was a problem hiding this comment.
on Sentry JavaScript for example, they use application/vnd.sentry.items.log+json by default on all requests
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 472960b+dirty | 394.39 ms | 376.18 ms | -18.20 ms |
| 3c99746+dirty | 400.65 ms | 399.59 ms | -1.06 ms |
| f870f2d+dirty | 398.49 ms | 434.24 ms | 35.75 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 472960b+dirty | 7.15 MiB | 8.34 MiB | 1.18 MiB |
| 3c99746+dirty | 7.15 MiB | 8.34 MiB | 1.18 MiB |
| f870f2d+dirty | 7.15 MiB | 8.34 MiB | 1.18 MiB |
CHANGELOG.md
Outdated
|
|
||
| ### Self Hosted | ||
|
|
||
| - It is recommended to use Sentry Self Hosted version `24.8.0` this and future versions. |
There was a problem hiding this comment.
I validated that capture of events/exceptions are working on 24.8.0, but we should at least recommend the first version suggested here getsentry/self-hosted#3560
CHANGELOG.md
Outdated
|
|
||
| ### Self Hosted | ||
|
|
||
| - It is recommended to use Sentry Self Hosted version `25.2.0` or new for React Native V7 or newer |
There was a problem hiding this comment.
this change affects all events/transactions due to the content type of the request being changed.
25.2.0 is a safe value for it getsentry/self-hosted#3560, even if we don't officially support logs, it'll not drop other types of content
|
@krystofwoldrich @antonis it's ready for review :D |
|
As tested here #4911 the failed tests are unrelated to this PR |
📢 Type of change
Blocked by:
📜 Description
Add the required changes on the Client in order to capture logs. All platforms will be supported with the initial PR (web, iOS and Android)
💡 Motivation and Context
Fixes #4856
💚 How did you test it?
Locally, with native SDKs disabled for testing the JavaScript integration, and with native SDKs enabled to test the Native integration
Pii
Pii seems to be filtered serverside so we don't need to do anything on the SDK.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps