Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Implement trace_propagation_targets for propagator #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

sl0thentr0py
Copy link
Member

No description provided.

@sl0thentr0py sl0thentr0py requested a review from a team as a code owner June 12, 2025 14:27
@sl0thentr0py sl0thentr0py force-pushed the neel/propagator-trace-prop-targets branch from bae199d to ed0f8d1 Compare June 12, 2025 14:29
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.79%. Comparing base (6ad4031) to head (ed0f8d1).
Report is 16 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/opentelemetry/propagator.py 78.57% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4460      +/-   ##
==============================================
- Coverage       84.79%   84.79%   -0.01%     
==============================================
  Files             144      144              
  Lines           14742    14794      +52     
  Branches         2346     2362      +16     
==============================================
+ Hits            12501    12544      +43     
+ Misses           1525     1523       -2     
- Partials          716      727      +11     
Files with missing lines Coverage Δ
sentry_sdk/opentelemetry/propagator.py 83.67% <78.57%> (-0.05%) ⬇️

... and 8 files with indirect coverage changes

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice test!

@sl0thentr0py sl0thentr0py merged commit 68b5116 into potel-base Jun 16, 2025
123 of 124 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/propagator-trace-prop-targets branch June 16, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.