Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

lforst
Copy link

@lforst lforst commented Dec 5, 2024

Some runtimes like QuickJS only have globalThis.

@lforst lforst requested a review from Lms24 December 5, 2024 11:44
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me! Do we also need to adjust something in Sentry CLI?

@lforst
Copy link
Author

lforst commented Dec 5, 2024

Sounds reasonable to me! Do we also need to adjust something in Sentry CLI?

absolutely!

@lforst lforst merged commit 10e4689 into main Dec 5, 2024
18 checks passed
@lforst lforst deleted the lforst-globalthis branch December 5, 2024 11:55
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 11, 2025
| datasource | package             | from   | to     |
| ---------- | ------------------- | ------ | ------ |
| npm        | @sentry/vite-plugin | 2.22.7 | 2.23.0 |


## [v2.23.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2230)

-   chore(deps): bump nanoid from 3.3.6 to 3.3.8 ([#641](getsentry/sentry-javascript-bundler-plugins#641))
-   feat(core): Detect Railway release name ([#639](getsentry/sentry-javascript-bundler-plugins#639))
-   feat(core): Write module injections to `globalThis` ([#636](getsentry/sentry-javascript-bundler-plugins#636))
-   feat(react-component-annotate): Allow skipping annotations on specified components ([#617](getsentry/sentry-javascript-bundler-plugins#617))
-   ref(core): Rename release management plugin name ([#647](getsentry/sentry-javascript-bundler-plugins#647))

Work in this release contributed by [@conor-ob](https://github.com/conor-ob). Thank you for your contribution!
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Jan 11, 2025
| datasource | package             | from   | to     |
| ---------- | ------------------- | ------ | ------ |
| npm        | @sentry/vite-plugin | 2.22.7 | 2.23.0 |


## [v2.23.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#2230)

-   chore(deps): bump nanoid from 3.3.6 to 3.3.8 ([#641](getsentry/sentry-javascript-bundler-plugins#641))
-   feat(core): Detect Railway release name ([#639](getsentry/sentry-javascript-bundler-plugins#639))
-   feat(core): Write module injections to `globalThis` ([#636](getsentry/sentry-javascript-bundler-plugins#636))
-   feat(react-component-annotate): Allow skipping annotations on specified components ([#617](getsentry/sentry-javascript-bundler-plugins#617))
-   ref(core): Rename release management plugin name ([#647](getsentry/sentry-javascript-bundler-plugins#647))

Work in this release contributed by [@conor-ob](https://github.com/conor-ob). Thank you for your contribution!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.