fix(react): Update types to match react router updates#5915
Closed
philipatkinson wants to merge 2 commits intogetsentry:mastergetsentry/sentry-javascript:masterfrom
Closed
fix(react): Update types to match react router updates#5915philipatkinson wants to merge 2 commits intogetsentry:mastergetsentry/sentry-javascript:masterfrom
philipatkinson wants to merge 2 commits intogetsentry:mastergetsentry/sentry-javascript:masterfrom
Conversation
Fixes a type mismatch caused by change remix-run/react-router#9366 in react-router code.
Contributor
|
Hey thanks for writing in! It seems this is causing some test failures with typing issues with |
Contributor
Author
|
Yes, I think this is because the devDependency in Sentry is set to react-router-dom 6.3 rather than 6.4.X. Had a quick fiddle to see if I could update and test easily, but yarn update was throwing out some strange errors. Will revisit when I have the chance to look in more detail (or we could leave it until the dependency naturally catches up and see if the tests pass then). |
3 tasks
|
Ey! Do you have a forecast for when it will be available? Thanks :) |
Contributor
|
Created #5992 to fix the test failures, will be shipped with the next release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a type mismatch caused by change remix-run/react-router#9366 in react-router code.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).