Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(node): Add ESM support for postgres.js instrumentation #17961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
Loading
from
Draft

feat(node): Add ESM support for postgres.js instrumentation #17961

wants to merge 1 commit into from

Conversation

onurtemizkan
Copy link
Collaborator

Resolves: #17889

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.64 kB - -
@sentry/browser - with treeshaking flags 23.14 kB - -
@sentry/browser (incl. Tracing) 40.99 kB - -
@sentry/browser (incl. Tracing, Replay) 79.29 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.98 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 84 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 96.16 kB - -
@sentry/browser (incl. Feedback) 41.33 kB - -
@sentry/browser (incl. sendFeedback) 29.3 kB - -
@sentry/browser (incl. FeedbackAsync) 34.26 kB - -
@sentry/react 26.35 kB - -
@sentry/react (incl. Tracing) 42.99 kB - -
@sentry/vue 29.13 kB - -
@sentry/vue (incl. Tracing) 42.79 kB - -
@sentry/svelte 24.66 kB - -
CDN Bundle 26.94 kB - -
CDN Bundle (incl. Tracing) 41.65 kB - -
CDN Bundle (incl. Tracing, Replay) 77.89 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 83.35 kB - -
CDN Bundle - uncompressed 78.95 kB - -
CDN Bundle (incl. Tracing) - uncompressed 123.53 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 238.54 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 251.31 kB - -
@sentry/nextjs (client) 45.06 kB - -
@sentry/sveltekit (client) 41.42 kB - -
@sentry/node-core 50.78 kB - -
@sentry/node 154.51 kB +0.07% +105 B 🔺
@sentry/node - without tracing 92.65 kB - -
@sentry/aws-serverless 106.35 kB - -

View base workflow run

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,511 - 9,119 -7%
GET With Sentry 1,344 16% 1,419 -5%
GET With Sentry (error only) 5,991 70% 6,192 -3%
POST Baseline 1,193 - 1,217 -2%
POST With Sentry 487 41% 525 -7%
POST With Sentry (error only) 1,043 87% 1,070 -3%
MYSQL Baseline 3,268 - 3,392 -4%
MYSQL With Sentry 403 12% 500 -19%
MYSQL With Sentry (error only) 2,634 81% 2,787 -5%

View base workflow run

@onurtemizkan onurtemizkan force-pushed the onur/postgres-js-esm-support branch from 837f3d8 to f635159 Compare October 17, 2025 09:40
@onurtemizkan onurtemizkan force-pushed the onur/postgres-js-esm-support branch from f635159 to 96641f9 Compare October 17, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sentry.postgresJsIntegration() not creating any DB spans

1 participant

@onurtemizkan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.