-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: Add cursor rules for dependency upgrades #16669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AbhiPrasad
wants to merge
7
commits into
develop
Choose a base branch
from
abhi-dependency-upgrade-rules
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+417
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armenzg
reviewed
Jun 20, 2025
Co-authored-by: Armen Zambrano G. <44410+armenzg@users.noreply.github.com>
andreiborza
reviewed
Jun 22, 2025
|
||
When upgrading OpenTelemetry dependencies: | ||
1. Check the dependency's `package.json` after upgrade | ||
2. Verify none of its dependencies use `@opentelemetry/*` packages at v2.0.0 or higher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: What's important is that any otel package is not on
- 2.x.x or
- 0.2xx.x or
- Any of its deps is bumping to those, e.g.
@opentelemetry/instrumentation-pg@0.52.0
bumped to core 2.0.0 and instrumentation 0.200.0
@@ -10264,6 +10264,11 @@ atob@^2.1.2: | ||
resolved "https://registry.yarnpkg.com/atob/-/atob-2.1.2.tgz#6d9517eb9e030d2436666651e86bd9f6f13533c9" | ||
integrity sha512-Wm6ukoaOGJi/73p/cl2GvLjTI5JM1k/O14isD73YML8StrH/7/lRFgmg8nICZgD3bZZvjwCGxtMOD3wWNAu8cg== | ||
|
||
atomic-sleep@^1.0.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: Why are there lockfile changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to unleash an army of background agents to crunch through https://github.com/getsentry/sentry-javascript/security/dependabot?q=is%3Aopen+
To do this, I added some cursor rules for upgrading dependencies within the repo.
I also tested this out with two dependabot security warnings:
resolves https://github.com/getsentry/sentry-javascript/security/dependabot/615
resolves https://github.com/getsentry/sentry-javascript/security/dependabot/613