Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(cloudflare): Import types explicitly from worker-types #16650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
Loading
from

Conversation

AbhiPrasad
Copy link
Member

resolves #16099

a little nervous about breaking durableobjects types, but I added a test so it should be fine.

@AbhiPrasad AbhiPrasad requested a review from a team June 18, 2025 21:20
@AbhiPrasad AbhiPrasad self-assigned this Jun 18, 2025
@AbhiPrasad AbhiPrasad requested review from Lms24 and chargome and removed request for a team June 18, 2025 21:20
@AbhiPrasad AbhiPrasad force-pushed the abhi-avoid-implicit-cloudflare-types-import branch from f69b3c7 to 3e08a52 Compare June 19, 2025 22:01
@AbhiPrasad
Copy link
Member Author

Hmm this still fails - going to draft while I figure it out.

// Although it is not ideal to use `any` here, it makes usage more flexible for different setups.
// eslint-disable-next-line @typescript-eslint/no-explicit-any
PluginParams = any,
> {
options: CloudflareOptions;
request: Request<unknown, IncomingRequestCfProperties<unknown>>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one needs to be typed more loosely?

AbhiPrasad added a commit to getsentry/sentry-docs that referenced this pull request Jun 20, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR

Explicitly using `Env` should help with some type issues. Part of
getsentry/sentry-javascript#16650

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

## LEGAL BOILERPLATE

<!-- Sentry employees and contractors can delete or ignore this section.
-->

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

## EXTRA RESOURCES

- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
@AbhiPrasad AbhiPrasad force-pushed the abhi-avoid-implicit-cloudflare-types-import branch from a804fb6 to cbc95cc Compare June 20, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sentry/cloudflare] Sentry import breaks Env type
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.