fix(v8/node/nestjs): Use method on current fastify request#15104
Merged
chargome merged 2 commits intov8getsentry/sentry-javascript:v8from Jan 21, 2025
cg/v8-backport-fastify-request-method-fixgetsentry/sentry-javascript:cg/v8-backport-fastify-request-method-fixCopy head branch name to clipboard
Merged
fix(v8/node/nestjs): Use method on current fastify request#15104chargome merged 2 commits intov8getsentry/sentry-javascript:v8from cg/v8-backport-fastify-request-method-fixgetsentry/sentry-javascript:cg/v8-backport-fastify-request-method-fixCopy head branch name to clipboard
chargome merged 2 commits intov8getsentry/sentry-javascript:v8from
cg/v8-backport-fastify-request-method-fixgetsentry/sentry-javascript:cg/v8-backport-fastify-request-method-fixCopy head branch name to clipboard
Conversation
The previous code was using fastify `request.routeOptions.method` which is all methods the current route supports - not the current request method. Ex. `@All()` nestjs decorator `request.routeOptions.method = ['GET', 'POST', 'HEAD', ...]` - Added a test for `@All()` - Updated instances of fastify request to use `request.method` which matches express --------- Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
mydea
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #15066