feat(user feedback): Create pen tool button for uf annotations#15102
Merged
c298lee merged 6 commits intocl/annotate-draw-toolgetsentry/sentry-javascript:cl/annotate-draw-toolfrom Jan 21, 2025
cl/draw-tool-buttongetsentry/sentry-javascript:cl/draw-tool-buttonCopy head branch name to clipboard
Merged
feat(user feedback): Create pen tool button for uf annotations#15102c298lee merged 6 commits intocl/annotate-draw-toolgetsentry/sentry-javascript:cl/annotate-draw-toolfrom cl/draw-tool-buttongetsentry/sentry-javascript:cl/draw-tool-buttonCopy head branch name to clipboard
c298lee merged 6 commits intocl/annotate-draw-toolgetsentry/sentry-javascript:cl/annotate-draw-toolfrom
cl/draw-tool-buttongetsentry/sentry-javascript:cl/draw-tool-buttonCopy head branch name to clipboard
Conversation
Contributor
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
ryan953
reviewed
Jan 21, 2025
ryan953
reviewed
Jan 21, 2025
Comment on lines
+79
to
+80
| const CropCorner = CropCornerFactory({ h }); | ||
| const PenIcon = PenIconFactory({ h }); |
Member
There was a problem hiding this comment.
Can you move these two lines up above the line return function ScreenshotEditor....
They should be in the same spot as the line const useTakeScreenshot = useTakeScreenshotFactory({ hooks });
ryan953
approved these changes
Jan 21, 2025
billyvg
approved these changes
Jan 21, 2025
| setIsAnnotating(!isAnnotating); | ||
| }} | ||
| > | ||
| <PenIcon></PenIcon> |
Member
There was a problem hiding this comment.
Hmm surprised prettier doesn't clean this up
c298lee
added a commit
that referenced
this pull request
Jan 21, 2025
…5062) - Updates some cropping variable names to make it more clear that it's only meant for cropping - The pen tool button is improved in #15102, which needs to be merged first - The drawing tool button needs to be "on" to annotate, but cropping can happen at any time - Once the button is "on", drawing happens on mouse down and mouse move, and on mouse up, the drawing gets "squashed" onto the image. The "squashing" can be moved to happen at a different time in a future PR if we want to incorporate undo, selection, or erasing - The experimental flag must be on to use annotations: `_experiments: {annotations: true}` https://github.com/user-attachments/assets/2fac5e56-5caf-454b-b8b3-afabbd2c31b9 Closes #15064 --------- Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a proper pen tool button. The icon for the button is from the hackweek project
Unselected:
Selected:
Relates to #15064