fix(node): Ensure NODE_OPTIONS is not passed to worker threads#14824
Merged
Lms24 merged 1 commit intodevelopgetsentry/sentry-javascript:developfrom Dec 23, 2024
timfish/fix/ensure-no-node-options-workergetsentry/sentry-javascript:timfish/fix/ensure-no-node-options-workerCopy head branch name to clipboard
Merged
fix(node): Ensure NODE_OPTIONS is not passed to worker threads#14824Lms24 merged 1 commit intodevelopgetsentry/sentry-javascript:developfrom timfish/fix/ensure-no-node-options-workergetsentry/sentry-javascript:timfish/fix/ensure-no-node-options-workerCopy head branch name to clipboard
NODE_OPTIONS is not passed to worker threads#14824Lms24 merged 1 commit intodevelopgetsentry/sentry-javascript:developfrom
timfish/fix/ensure-no-node-options-workergetsentry/sentry-javascript:timfish/fix/ensure-no-node-options-workerCopy head branch name to clipboard
Conversation
Contributor
size-limit report 📦
|
Lms24
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like
execArgvcan cause--importand--requireto be preloaded in worker threads and cause infinite loops,NODE_OPTIONScan cause this too.