feat(core)!: Remove getDomElement method#14797
Merged
mydea merged 3 commits intodevelopgetsentry/sentry-javascript:developfrom Dec 19, 2024
fn/remove-getDomElementgetsentry/sentry-javascript:fn/remove-getDomElementCopy head branch name to clipboard
Merged
feat(core)!: Remove getDomElement method#14797mydea merged 3 commits intodevelopgetsentry/sentry-javascript:developfrom fn/remove-getDomElementgetsentry/sentry-javascript:fn/remove-getDomElementCopy head branch name to clipboard
getDomElement method#14797mydea merged 3 commits intodevelopgetsentry/sentry-javascript:developfrom
fn/remove-getDomElementgetsentry/sentry-javascript:fn/remove-getDomElementCopy head branch name to clipboard
Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Dec 19, 2024
mydea
added a commit
that referenced
this pull request
Dec 19, 2024
Backported deprecation of #14797
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this in #14758, this seems unnecessary and all browsers/envs we support should be able to handle this. We only use this in two places anyhow, so we can just guard there (a bit) for this instead.
I will add a deprecation to v8 for this too, although this is just exported from core and will most likely not affect anybody.