feat(node): Do not overwrite prisma db.system in newer Prisma versions#14771
Merged
mydea merged 1 commit intodevelopgetsentry/sentry-javascript:developfrom Dec 18, 2024
fn/prisma-no-db-systemgetsentry/sentry-javascript:fn/prisma-no-db-systemCopy head branch name to clipboard
Merged
feat(node): Do not overwrite prisma db.system in newer Prisma versions#14771mydea merged 1 commit intodevelopgetsentry/sentry-javascript:developfrom fn/prisma-no-db-systemgetsentry/sentry-javascript:fn/prisma-no-db-systemCopy head branch name to clipboard
db.system in newer Prisma versions#14771mydea merged 1 commit intodevelopgetsentry/sentry-javascript:developfrom
fn/prisma-no-db-systemgetsentry/sentry-javascript:fn/prisma-no-db-systemCopy head branch name to clipboard
Conversation
This was referenced Dec 18, 2024
Lms24
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v5.22, Prisma properly adds the
db.systemto it's OTEL spans.This PR fixes the behavior so we do not overwrite it. For now, I left the fallback behavior in, that would add it if
db.systemis missing - as otherwise this would "break" on older prisma versions.This also needs to be backported to v8.