Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: Allow capture of more than 1 ANR event#14684

Merged
AbhiPrasad merged 2 commits intodevelopgetsentry/sentry-javascript:developfrom
timfish/feat/anr-multiplegetsentry/sentry-javascript:timfish/feat/anr-multipleCopy head branch name to clipboard
Dec 13, 2024
Merged

feat: Allow capture of more than 1 ANR event#14684
AbhiPrasad merged 2 commits intodevelopgetsentry/sentry-javascript:developfrom
timfish/feat/anr-multiplegetsentry/sentry-javascript:timfish/feat/anr-multipleCopy head branch name to clipboard

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Dec 12, 2024

Adds a maxAnrEvents option to the ANR integration which allows you to capture more than one event.

@codecov
Copy link

codecov bot commented Dec 12, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
210 1 209 9
View the top 1 failed tests by shortest run time
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes
Stack Traces | 30s run time
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for this please, I want to make sure this doesn't regress

@timfish timfish requested a review from AbhiPrasad December 13, 2024 15:46
Copy link
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also backport this to v8 as well

@AbhiPrasad AbhiPrasad merged commit 33b3b23 into develop Dec 13, 2024
@AbhiPrasad AbhiPrasad deleted the timfish/feat/anr-multiple branch December 13, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ANR only sends one event

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.