feat(node): Add Gitlab CI support in getSentryRelease #12507
Conversation
|
Hey! thanks for the PR :) We'll merge this in soon - let me update https://github.com/getsentry/sentry-javascript-bundler-plugins/ first! |
|
Looking at codecov there seems to be more environmental variables that are Gitlab specific! https://github.com/codecov/codecov-cli/blob/24d49dd4a4e879687218faf97cfc6f5b9d83a413/codecov_cli/helpers/ci_adapters/gitlab_ci.py#L14-L16 |
|
Hey, I only added the commit sha to stay consistent with the rest of the values for the other providers. |
|
Just saw you opened a PR for a lot more providers and you won't need this, thanks for taking care of this so fast :) |
|
@MarcEspiard I will prob open a new PR and sort out the ordering, I'll just cherry-pick your commit to you get the contribution creds. Thanks again for the PR, it's a good reminder for us to get this logic working consistently everywhere! |
|
Closing this in favour of #12529 and getsentry/sentry-javascript-bundler-plugins#549 |
ref #12513 This PR upgrades release detection for Node and Vercel Edge SDKs. This change adds release name detection for: - GitLab CI - AppVeyor - AWS Amplify - Azure Pipelines - Bitrise - Buddy CI - Cirrus CI - Codefresh - Codemagic - Semaphore CI - Travis CI - CloudBees CodeShip - Coolify - Jenkins - TeamCity - Woodpecker CI Based on getsentry/sentry-javascript-bundler-plugins#549 Supercedes #12507
Adds support for Gitlab CI/CD in getSentryRelease function