Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Sep 24, 2025

📜 Description

app start continuous profiler will now start performance collection when the SDK inits

💡 Motivation and Context

app start continuous profiles were missing performance data on first chunk (cpu and ram)

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps


Note

Start performance collector when AppStart continuous profiler is active during SDK init; add getChunkId to continuous profiler and update related logic/tests.

  • Android Core:
    • Start performance collection on SDK init if AppStart continuous profiler is running; pass CompositePerformanceCollector to setupProfiler and call start(chunkId).
    • Expose getChunkId on IContinuousProfiler and implement in AndroidContinuousProfiler; reset profilerId/chunkId appropriately; use .equals for SentryId checks.
    • Adjust AndroidOptionsInitializer ordering and wiring; reuse app-start profilers; ensure performance collectors initialized before profiler setup.
  • Tests:
    • Add/extend tests for starting performance collection with running AppStart profiler, chunkId behavior, rate-limit/offline resets, and chunk restarts.
  • API/Docs:
    • Update public API (sentry.api, sentry-android-core.api) and CHANGELOG to reflect new method and behavior.

Written by Cursor Bugbot for commit 55e1f87. This will update automatically on new commits. Configure here.

@stefanosiano stefanosiano marked this pull request as ready for review September 24, 2025 13:43
Copy link
Contributor

github-actions bot commented Sep 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 355.30 ms 426.39 ms 71.09 ms
Size 1.58 MiB 2.10 MiB 533.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1df7eb6 397.04 ms 429.64 ms 32.60 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms
c8125f3 383.82 ms 441.66 ms 57.84 ms
d217708 411.22 ms 430.86 ms 19.63 ms
d217708 375.27 ms 415.68 ms 40.41 ms
ee747ae 386.94 ms 431.43 ms 44.49 ms
17a0955 372.53 ms 446.70 ms 74.17 ms
f634d01 375.06 ms 420.04 ms 44.98 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
ee747ae 400.46 ms 423.61 ms 23.15 ms

App size

Revision Plain With Sentry Diff
1df7eb6 1.58 MiB 2.10 MiB 532.97 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
17a0955 1.58 MiB 2.10 MiB 533.20 KiB
f634d01 1.58 MiB 2.10 MiB 533.40 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: stefanosiano/fix/continuous-profiler-performance-collection

Startup times

Revision Plain With Sentry Diff
360daf3 381.59 ms 456.00 ms 74.41 ms

App size

Revision Plain With Sentry Diff
360daf3 1.58 MiB 2.10 MiB 533.11 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, but lgtm otherwise

@stefanosiano stefanosiano enabled auto-merge (squash) September 29, 2025 15:31
@stefanosiano stefanosiano merged commit 806307f into main Sep 29, 2025
62 of 63 checks passed
@stefanosiano stefanosiano deleted the stefanosiano/fix/continuous-profiler-performance-collection branch September 29, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.