-
-
Notifications
You must be signed in to change notification settings - Fork 459
Start performance collection on AppStart continuous profiling #4752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stefanosiano
merged 4 commits into
main
from
stefanosiano/fix/continuous-profiler-performance-collection
Sep 29, 2025
Merged
Start performance collection on AppStart continuous profiling #4752
stefanosiano
merged 4 commits into
main
from
stefanosiano/fix/continuous-profiler-performance-collection
Sep 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1df7eb6 | 397.04 ms | 429.64 ms | 32.60 ms |
ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
c8125f3 | 383.82 ms | 441.66 ms | 57.84 ms |
d217708 | 411.22 ms | 430.86 ms | 19.63 ms |
d217708 | 375.27 ms | 415.68 ms | 40.41 ms |
ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
17a0955 | 372.53 ms | 446.70 ms | 74.17 ms |
f634d01 | 375.06 ms | 420.04 ms | 44.98 ms |
ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1df7eb6 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
17a0955 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
f634d01 | 1.58 MiB | 2.10 MiB | 533.40 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
markushi
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
romtsn
reviewed
Sep 29, 2025
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, but lgtm otherwise
…ance-collection # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
app start continuous profiler will now start performance collection when the SDK inits
💡 Motivation and Context
app start continuous profiles were missing performance data on first chunk (cpu and ram)
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps
Note
Start performance collector when AppStart continuous profiler is active during SDK init; add
getChunkId
to continuous profiler and update related logic/tests.CompositePerformanceCollector
tosetupProfiler
and callstart(chunkId)
.getChunkId
onIContinuousProfiler
and implement inAndroidContinuousProfiler
; resetprofilerId
/chunkId
appropriately; use.equals
forSentryId
checks.AndroidOptionsInitializer
ordering and wiring; reuse app-start profilers; ensure performance collectors initialized before profiler setup.chunkId
behavior, rate-limit/offline resets, and chunk restarts.sentry.api
,sentry-android-core.api
) and CHANGELOG to reflect new method and behavior.Written by Cursor Bugbot for commit 55e1f87. This will update automatically on new commits. Configure here.