Mark SentryEnvelope as not internal
#4748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 馃殌
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 415.92 ms | 470.15 ms | 54.23 ms |
| d217708 | 411.22 ms | 430.86 ms | 19.63 ms |
| d217708 | 355.34 ms | 381.39 ms | 26.05 ms |
| ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
| c8125f3 | 383.82 ms | 441.66 ms | 57.84 ms |
| b750b96 | 421.25 ms | 444.09 ms | 22.84 ms |
| 3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
| 3998a95 | 415.94 ms | 478.54 ms | 62.60 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| 23d6b12 | 354.10 ms | 408.38 ms | 54.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
| 3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| 3998a95 | 1.58 MiB | 2.10 MiB | 532.96 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 23d6b12 | 1.58 MiB | 2.10 MiB | 532.31 KiB |
lcian
commented
Sep 23, 2025
SentryEnvelope as not internal
adinauer
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
To implement a custom transport, a user needs to define
ITransport::sendwhich takes aSentryEnvelope, so we should mark that one as not internal.Other than that, this particular user also mentioned
SentryEnvelopeHeader, SentryEnvelopeItem, SentryItemType, but I would avoid making those not internal unless they confirm they really need it for their usecase.馃挕 Motivation and Context
Close #4722
Close JAVA-175