Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add origin to logs #4618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2025
Merged

Add origin to logs #4618

merged 4 commits into from
Aug 8, 2025

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Aug 7, 2025 •
edited
Loading

馃摐 Description

Sends the sentry.origin attribute to Sentry.
For integrations this is set to e.g. sentry.log.logcat, sentry.log.logback, ...
The default is manual.

馃挕 Motivation and Context

So we know what's creating logs.

馃挌 How did you test it?

馃摑 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@adinauer adinauer marked this pull request as ready for review August 7, 2025 14:19
@adinauer Graphite App
Copy link
Member Author

adinauer commented Aug 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

cursor[bot]

This comment was marked as outdated.

Sign in to view

@adinauer adinauer force-pushed the 08-07-add_origin_to_logs branch from 8feaf5a to dfbdbe5 Compare August 7, 2025 14:23
@adinauer adinauer force-pushed the 08-07-add_origin_to_logs branch from dfbdbe5 to 93ff861 Compare August 7, 2025 14:27
@adinauer
Copy link
Member Author

adinauer commented Aug 7, 2025

@sentry review

@adinauer
Copy link
Member Author

adinauer commented Aug 7, 2025

cursor review

cursor[bot]

This comment was marked as outdated.

Sign in to view

romtsn
romtsn approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

seer-by-sentry[bot]
seer-by-sentry bot reviewed Aug 7, 2025
View reviewed changes
sentry/src/main/java/io/sentry/logger/LoggerApi.java Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025 •
edited
Loading

Performance metrics 馃殌

聽 Plain With Sentry Diff
Startup time 422.51 ms 465.47 ms 42.96 ms
Size 1.58 MiB 2.09 MiB 522.31 KiB

Previous results on branch: 08-07-add_origin_to_logs

Startup times

Revision Plain With Sentry Diff
8c9b73e 433.98 ms 480.59 ms 46.61 ms
c8b0567 419.61 ms 480.96 ms 61.35 ms

App size

Revision Plain With Sentry Diff
8c9b73e 1.58 MiB 2.09 MiB 522.31 KiB
c8b0567 1.58 MiB 2.09 MiB 522.31 KiB

@adinauer adinauer merged commit f2b0ffb into main Aug 8, 2025
36 of 37 checks passed
@adinauer adinauer deleted the 08-07-add_origin_to_logs branch August 8, 2025 11:58
@antonis antonis mentioned this pull request Aug 11, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seer-by-sentry seer-by-sentry[bot] seer-by-sentry[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

@romtsn romtsn romtsn approved these changes

@lcian lcian lcian approved these changes

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adinauer @romtsn @lcian @alexander-alderman-webb
Morty Proxy This is a proxified and sanitized view of the page, visit original site.