Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Draft
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
92b2fbe
Define option to enable logs
limbonaut Oct 6, 2025
55953f1
Add intermediary logging API (as log() method for now) on Apple
limbonaut Oct 7, 2025
f484ea5
Enable logs in the project
limbonaut Oct 7, 2025
437ca29
Add structured log call to project (a test)
limbonaut Oct 7, 2025
2df8297
Change arg order in temporary API method
limbonaut Oct 7, 2025
bbf9c52
Add incomplete native implementation
limbonaut Oct 7, 2025
0b3be7a
Add initial Android implementation
limbonaut Oct 7, 2025
c576edb
Add SentrySDK.logger API
limbonaut Oct 7, 2025
e62c253
Add default values
limbonaut Oct 8, 2025
0a5f97d
Update enrich_events.gd
limbonaut Oct 8, 2025
a911727
Add optimized path for log() on Android
limbonaut Oct 8, 2025
678ac95
Add class descriptions for similar-named SentryLogger and
limbonaut Oct 8, 2025
7ea4b60
Introduce SentryLogLevel enum
limbonaut Oct 8, 2025
792402a
Fix attributes on Android
limbonaut Oct 8, 2025
605fa60
Fix logger test
limbonaut Oct 8, 2025
4dc480f
Add logger.trace()
limbonaut Oct 8, 2025
e58ed52
Introduce experimental options
limbonaut Oct 8, 2025
b3eb911
Fix using experimental option
limbonaut Oct 8, 2025
34db858
Processing structure
limbonaut Oct 8, 2025
77fb5e8
Expland SentryLog, add CocoaLog
limbonaut Oct 8, 2025
d109deb
Export SentryLog API
limbonaut Oct 9, 2025
539dbdf
Add Log.add_attributes() and log.remove_attribute() with Cocoa
limbonaut Oct 9, 2025
b778863
Add NativeLog implementation
limbonaut Oct 9, 2025
3d538c4
Move enum to SentryLog
limbonaut Oct 9, 2025
00a202d
Fix cocoa util variant conversion
limbonaut Oct 9, 2025
2a1dbea
Add tests
limbonaut Oct 9, 2025
a49dba5
Register NativeLog class
limbonaut Oct 9, 2025
b6eb22a
Add mostly implemented AndroidLog
limbonaut Oct 10, 2025
5f7957f
add_attributes and remove_attribute on Android
limbonaut Oct 10, 2025
deba6ae
Fix cutting UTF-8 strings
limbonaut Oct 10, 2025
db26f47
Fix get_attribute() on Android
limbonaut Oct 10, 2025
50c6729
Add mobile tests for structured logs
limbonaut Oct 10, 2025
194377b
Forgot mobile test support in main loop
limbonaut Oct 10, 2025
53c5573
Add UTF-8 test
limbonaut Oct 10, 2025
c810112
Undo changes in enrich_events.gd
limbonaut Oct 10, 2025
06e8005
Fixes for NativeLog
limbonaut Oct 10, 2025
61eba8a
Fix memleak with SentrySDK.logger
limbonaut Oct 10, 2025
16f5f74
Improve native log type error message
limbonaut Oct 10, 2025
b887455
Don't print to engine logger within another log operation
limbonaut Oct 10, 2025
0848118
Fixes for NativeLog
limbonaut Oct 10, 2025
92c69d0
Don't discard event, so not to trigger debug printing
limbonaut Oct 10, 2025
4d0452a
logging: Move print.h to logging
limbonaut Oct 11, 2025
cd61aa6
Move print & logger into logging, extract logging state
limbonaut Oct 11, 2025
fd4290d
Log runtime errors
limbonaut Oct 13, 2025
25f7d14
Log more error attributes
limbonaut Oct 13, 2025
d63a1be
Merge branch 'main' into feat/structured-logging
limbonaut Oct 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix attributes on Android
  • Loading branch information
limbonaut committed Oct 8, 2025
commit 792402adf547997fbfa636f931350bb8b8dd407d
26 changes: 4 additions & 22 deletions 26 src/sentry/android/android_sdk.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,9 @@ using namespace godot;

namespace {

Dictionary _as_attribute(const Variant &p_value) {
Dictionary attr;
switch (p_value.get_type()) {
case Variant::BOOL: {
attr["type"] = "boolean";
attr["value"] = p_value;
} break;
case Variant::INT: {
attr["type"] = "integer";
attr["value"] = p_value;
} break;
case Variant::FLOAT: {
attr["type"] = "double";
attr["value"] = p_value;
} break;
default: {
attr["type"] = "string";
attr["value"] = p_value.stringify();
} break;
}
return attr;
inline Variant _as_attribute(const Variant &p_value) {
Variant::Type type = p_value.get_type();
return (type < Variant::BOOL || type > Variant::STRING) ? (Variant)p_value.stringify() : p_value;
}

} // unnamed namespace
Expand Down Expand Up @@ -134,7 +116,7 @@ void AndroidSDK::log(LogLevel p_level, const String &p_body, const Array &p_para
Dictionary attributes;

if (has_params) {
attributes["sentry.message.template"] = _as_attribute(body);
attributes["sentry.message.template"] = body;
for (int i = 0; i < p_params.size(); i++) {
String key = "sentry.message.parameter." + itos(i);
attributes[key] = _as_attribute(p_params[i]);
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.