Add owner option for check-ins
#879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
reviewed
Apr 5, 2025
| failure_issue_threshold: number_schema_opts, | ||
| recovery_threshold: number_schema_opts, | ||
| timezone: [type: :string], | ||
| owner: [type: :string], |
There was a problem hiding this comment.
Can we say something like this in the docs for this type:
The type for the check-in struct.
`:owner` is available since v10.10.0.
There was a problem hiding this comment.
good call. I extracted the config into its own type to make it clearer
owner option to Checking.monitor_configowner option to Checking.monitor_config
owner option to Checking.monitor_configowner option for check-ins
whatyouhide
approved these changes
Apr 7, 2025
|
Thanks @Miradorn 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #824 for real :D