fix: Potential app launch hang caused by the SDK #6181
Merged
+6
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused crash report fields binary_cpu_type and binary_cpu_subtype so we can also remove the call to _dyld_get_image_header, which lead to app launch hangs for a customer. Still, these fields might be useful and we can readd them with GH-6180.
❌ 1 Tests Failed:
View the top 2 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
noahsmartin
approved these changes
Sep 17, 2025
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 07d7e83 | 1211.71 ms | 1240.08 ms | 28.37 ms |
| 42cfd79 | 1222.13 ms | 1244.23 ms | 22.10 ms |
| 50a9ff7 | 1221.43 ms | 1238.07 ms | 16.64 ms |
| 073562b | 1232.63 ms | 1259.88 ms | 27.24 ms |
| f262e10 | 1226.88 ms | 1250.39 ms | 23.51 ms |
| 5db87fa | 1218.88 ms | 1251.53 ms | 32.65 ms |
| c30e401 | 1218.71 ms | 1243.73 ms | 25.02 ms |
| e36128b | 1213.04 ms | 1248.60 ms | 35.56 ms |
| 891fd1d | 1220.02 ms | 1227.60 ms | 7.57 ms |
| 9e0030e | 1222.78 ms | 1242.23 ms | 19.45 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 07d7e83 | 23.75 KiB | 913.27 KiB | 889.52 KiB |
| 42cfd79 | 23.75 KiB | 880.20 KiB | 856.45 KiB |
| 50a9ff7 | 23.75 KiB | 913.63 KiB | 889.89 KiB |
| 073562b | 23.75 KiB | 927.06 KiB | 903.31 KiB |
| f262e10 | 23.75 KiB | 913.62 KiB | 889.87 KiB |
| 5db87fa | 23.75 KiB | 926.65 KiB | 902.90 KiB |
| c30e401 | 23.74 KiB | 971.70 KiB | 947.96 KiB |
| e36128b | 23.75 KiB | 963.19 KiB | 939.44 KiB |
| 891fd1d | 23.75 KiB | 919.92 KiB | 896.17 KiB |
| 9e0030e | 23.75 KiB | 893.72 KiB | 869.97 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove unused crash report fields binary_cpu_type and binary_cpu_subtype so we can also remove the call to _dyld_get_image_header, which lead to app launch hangs for a customer. Still, these
fields might be useful and we can readd them with GH-6180.
💡 Motivation and Context
Quick fix for #6180
💚 How did you test it?
binary_cpu_subtypeandbinary_cpu_type, so we test that if previous reports contain this info, we handle it correctly.📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.