Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore(ci): React-Native: Adds missing self to make capture semantics explicit #6156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

chore(ci): React-Native: Adds missing self to make capture semantics explicit #6156

merged 3 commits into from
Sep 12, 2025

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Sep 12, 2025 •
edited
Loading

📜 Description

Adds missing self to make capture semantics explicit in react native legacy builds in 8.56.0-alpha.2

💡 Motivation and Context

React native CI error

Error: reference to property 'connectedScenes' in closure requires explicit use of 'self' to make capture semantics explicit
                let scenes = connectedScenes
                             ^
Error: reference to property 'delegate' in closure requires explicit use of 'self' to make capture semantics explicit
            if let window = delegate?.window {

example ci failure (test PR)

💚 How did you test it?

CI

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Closes #6157

@codecov Codecov
Copy link

codecov bot commented Sep 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.620%. Comparing base (89e74bc) to head (2682205).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6156       +/-   ##
=============================================
+ Coverage   86.451%   86.620%   +0.169%     
=============================================
  Files          435       435               
  Lines        36970     36983       +13     
  Branches     15793     17391     +1598     
=============================================
+ Hits         31961     32035       +74     
+ Misses        4969      4901       -68     
- Partials        40        47        +7
Files with missing lines Coverage Δ
...ces/Swift/Helper/SentryApplicationExtensions.swift 20.769% <100.000%> (ø)

... and 20 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e74bc...2682205. Read the comment docs.

@antonis antonis marked this pull request as ready for review September 12, 2025 10:59
@github-actions github-actions bot mentioned this pull request Sep 12, 2025
Closed
7 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1212.30 ms 1236.56 ms 24.26 ms
Size 23.75 KiB 969.78 KiB 946.03 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d8b2303 1231.53 ms 1249.89 ms 18.35 ms
7908e84 1224.33 ms 1246.39 ms 22.06 ms
83bb978 1238.33 ms 1260.04 ms 21.71 ms
5712478 1220.10 ms 1239.69 ms 19.59 ms
139db8b 1231.50 ms 1258.19 ms 26.69 ms
53b722c 1222.33 ms 1244.90 ms 22.56 ms
9be5373 1215.92 ms 1239.44 ms 23.52 ms
570f725 1206.00 ms 1238.96 ms 32.96 ms
2e79f5f 1220.53 ms 1249.35 ms 28.82 ms
d05d866 1211.78 ms 1230.96 ms 19.18 ms

App size

Revision Plain With Sentry Diff
d8b2303 23.75 KiB 908.02 KiB 884.27 KiB
7908e84 23.74 KiB 872.75 KiB 849.00 KiB
83bb978 23.75 KiB 920.64 KiB 896.89 KiB
5712478 23.75 KiB 969.28 KiB 945.54 KiB
139db8b 23.75 KiB 920.64 KiB 896.89 KiB
53b722c 23.75 KiB 906.08 KiB 882.33 KiB
9be5373 23.75 KiB 866.50 KiB 842.75 KiB
570f725 23.74 KiB 913.38 KiB 889.63 KiB
2e79f5f 23.75 KiB 928.87 KiB 905.12 KiB
d05d866 23.75 KiB 878.60 KiB 854.85 KiB

Previous results on branch: antonis/rn-fix-missing-self

Startup times

Revision Plain With Sentry Diff
b3751d3 1237.88 ms 1268.37 ms 30.49 ms

App size

Revision Plain With Sentry Diff
b3751d3 23.75 KiB 969.78 KiB 946.03 KiB

philprime
philprime reviewed Sep 12, 2025
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@philprime philprime enabled auto-merge (squash) September 12, 2025 12:00
@philprime philprime merged commit 5cbd333 into main Sep 12, 2025
173 of 176 checks passed
@philprime philprime deleted the antonis/rn-fix-missing-self branch September 12, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philprime philprime philprime approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann is a code owner

@noahsmartin noahsmartin Awaiting requested review from noahsmartin noahsmartin is a code owner

@itaybre itaybre Awaiting requested review from itaybre itaybre is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore(ci): React-Native: Adds missing self to make capture semantics explicit

2 participants

@antonis @philprime
Morty Proxy This is a proxified and sanitized view of the page, visit original site.