feat: Replace user.ipAddress = {{auto}} with a new settings.infer_ip property in the sdk metadata
#5877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5877 +/- ##
========================================
Coverage ? 86.717%
========================================
Files ? 424
Lines ? 36635
Branches ? 17356
========================================
Hits ? 31769
Misses ? 4821
Partials ? 45
Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ebc72be | 1221.24 ms | 1249.66 ms | 28.42 ms |
| fc0757d | 1231.83 ms | 1248.98 ms | 17.15 ms |
| f97a070 | 1218.88 ms | 1253.12 ms | 34.24 ms |
| f5d202b | 1237.90 ms | 1259.49 ms | 21.59 ms |
| 1a34ddc | 1218.94 ms | 1251.86 ms | 32.92 ms |
| ea5a59b | 1222.87 ms | 1253.47 ms | 30.60 ms |
| 83bb978 | 1238.33 ms | 1260.04 ms | 21.71 ms |
| fdea6f5 | 1216.08 ms | 1241.82 ms | 25.73 ms |
| ccf1278 | 1226.84 ms | 1248.51 ms | 21.67 ms |
| 9e0030e | 1222.78 ms | 1242.23 ms | 19.45 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ebc72be | 23.75 KiB | 908.22 KiB | 884.47 KiB |
| fc0757d | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| f97a070 | 23.75 KiB | 858.68 KiB | 834.93 KiB |
| f5d202b | 23.75 KiB | 904.53 KiB | 880.78 KiB |
| 1a34ddc | 23.75 KiB | 919.88 KiB | 896.13 KiB |
| ea5a59b | 23.75 KiB | 874.46 KiB | 850.71 KiB |
| 83bb978 | 23.75 KiB | 920.64 KiB | 896.89 KiB |
| fdea6f5 | 23.75 KiB | 867.15 KiB | 843.40 KiB |
| ccf1278 | 23.75 KiB | 877.15 KiB | 853.40 KiB |
| 9e0030e | 23.75 KiB | 893.72 KiB | 869.97 KiB |
philprime
approved these changes
Aug 12, 2025
3f40146 to
7604a6d
Compare
…p property in the sdk metadata
7604a6d to
4462446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new class to handle SDK settings, for now only
infer_ipis needed but given this name, it will probably be used for more attributes.Updates all tests using SentrySDKInfotoo
Implements: #5219
Given that no changes are made in the public API: #skip-changelog