This repository was archived by the owner on Aug 14, 2024. It is now read-only.
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
72bd300 to
f918ff2
Compare
jjbayer
reviewed
Apr 18, 2024
| "endTimeUnixNano": "1544712661000000000", | ||
| "attributes": [ | ||
| { | ||
| "key": "sentry.segment.id", |
Member
There was a problem hiding this comment.
Still not 100% if sentry.segment_id would be better. I personally like the nesting but the Otel docs are ambiguous about it:
Namespaces can be nested. For example telemetry.sdk is a namespace inside top-level telemetry namespace and telemetry.sdk.name is an attribute inside telemetry.sdk namespace.
but
the fact that an entity is located within another entity is typically not a sufficient reason for forming nested namespaces. The purpose of a namespace is to avoid name clashes, not to indicate entity hierarchies.
https://opentelemetry.io/docs/specs/semconv/general/attribute-naming/
When in doubt, I would keep the ..
jjbayer
reviewed
Apr 22, 2024
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
jjbayer
added a commit
to getsentry/relay
that referenced
this pull request
Apr 22, 2024
To simplify conversion in the future, align attribute names in Otel's span attributes with keys in Sentry's `span.data`. The old keys in `span.data` remain as legacy alias. See also getsentry/develop#1230 for the span schema / attribute convention. ref: #3278 --------- Co-authored-by: David Herberth <david.herberth@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://develop-git-new-span-schema.sentry.dev/sdk/event-payloads/only-spans/