Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Modernize fork: upgrade deps, log4j2, versions-maven-plugin#1

Merged
mariuszpala merged 2 commits intomastergeneriscorp/java-saml:masterfrom
developgeneriscorp/java-saml:developCopy head branch name to clipboard
Feb 9, 2026
Merged

Modernize fork: upgrade deps, log4j2, versions-maven-plugin#1
mariuszpala merged 2 commits intomastergeneriscorp/java-saml:masterfrom
developgeneriscorp/java-saml:developCopy head branch name to clipboard

Conversation

@mariuszpala
Copy link
Collaborator

@mariuszpala mariuszpala commented Feb 8, 2026

Summary

  • Fork identity: Changed groupId to com.generiscorp, updated SCM URLs, version set to 3.0.3-SNAPSHOT
  • Dependency upgrades: All dependencies updated to latest stable versions (xmlsec 4.0.4, commons-lang3 3.20.0, commons-codec 1.21.0, slf4j 2.0.17, Azure KeyVault 4.10.2, Azure Identity 1.18.2)
  • Logging: Replaced Logback with Log4j2 (log4j-core + log4j-slf4j2-impl, both optional)
  • Testing: Added JUnit 5 BOM with vintage engine for backward compatibility, upgraded Mockito to 5.21.0, Hamcrest to 3.0. Fixed org.mockito.Matchersorg.mockito.ArgumentMatchers for Mockito 5.x compatibility. Fixed xmlsec error message change in test assertion.
  • Build tooling: Added versions-maven-plugin to report available dependency updates during build, added OWASP dependency-check-maven, centralized all version properties in parent POM
  • Cleanup: Removed samples module, updated README with fork documentation and migration guide

Test plan

  • All 464 tests passing (373 core + 91 toolkit)
  • Verify build on CI
  • Validate dependency versions with mvn versions:display-dependency-updates

…ns-maven-plugin

Major changes from upstream SAML-Toolkits/java-saml v2.9.0:

- Change groupId from com.onelogin to com.generiscorp (Java packages unchanged)
- Bump version to 3.0.3-SNAPSHOT
- Replace logback-classic with log4j2 + log4j-slf4j2-impl (aligns with cara ecosystem)
- Upgrade all dependencies to latest stable:
  - xmlsec 3.0.2 → 4.0.4 (CVE fixes)
  - SLF4J 1.7.36 → 2.0.17
  - commons-lang3 3.13.0 → 3.20.0
  - commons-codec 1.16.0 → 1.21.0
  - azure-keyvault 4.7.0 → 4.10.2
  - azure-identity 1.10.1 → 1.18.2
  - mockito 3.12.4 → 5.21.0
  - hamcrest 2.2 → 3.0
- Add JUnit 5 BOM + vintage engine (existing JUnit 4 tests run unchanged)
- Upgrade all Maven plugins to latest stable versions
- Add versions-maven-plugin (runs during validate phase, reports outdated deps)
- Centralize all version numbers as properties in parent POM
- Add pluginManagement for surefire, jacoco, jar, compiler
- Update SCM URLs to point to generiscorp/java-saml
- Remove samples module
- Fix test assertion for changed xmlsec error message
- Fix deprecated org.mockito.Matchers → org.mockito.ArgumentMatchers

All 464 tests passing.
Copy link
Collaborator

@karolbe karolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge

@mariuszpala mariuszpala merged commit 06488d2 into master Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.